Skip to content

Commit bd82635

Browse files
gennaroprotagennaroprota
committed
fix: render true booleans as "true" in XML output
The XML writer emitted true boolean members as `<x>1</x>` (and omitted the element when false). It now emits the xsd:boolean primary lexical form, `<x>true</x>`. The omit-when-false convention is preserved, so the golden XMLs change only in the body of already-present boolean elements. The RELAX NG schema is updated accordingly.
1 parent 1fc06a0 commit bd82635

209 files changed

Lines changed: 2287 additions & 2287 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎mrdocs.rnc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ grammar
6969

7070
SymbolID = text # Base64-encoded
7171

72-
Bool = "1"
72+
Bool = "true"
7373

7474
#---------------------------------------------
7575
# Enums

‎src/lib/Gen/xml/XMLWriter.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ XMLWriter::write(T const& value)
111111
// Primitives: write as text content
112112
if constexpr (std::is_same_v<Type, bool>)
113113
{
114-
os_ << '1';
114+
os_ << "true";
115115
}
116116
else if constexpr (std::is_same_v<Type, std::string> ||
117117
std::is_same_v<Type, dom::String> ||

‎test-files/golden-tests/config/auto-brief/auto-brief.xml‎

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
<source-path>auto-brief.cpp</source-path>
5050
<line-number>70</line-number>
5151
<column-number>1</column-number>
52-
<documented>1</documented>
52+
<documented>true</documented>
5353
</location>
5454
</source>
5555
<kind>function</kind>
@@ -82,7 +82,7 @@
8282
<source-path>auto-brief.cpp</source-path>
8383
<line-number>48</line-number>
8484
<column-number>1</column-number>
85-
<documented>1</documented>
85+
<documented>true</documented>
8686
</location>
8787
</source>
8888
<kind>function</kind>
@@ -115,7 +115,7 @@
115115
<source-path>auto-brief.cpp</source-path>
116116
<line-number>60</line-number>
117117
<column-number>1</column-number>
118-
<documented>1</documented>
118+
<documented>true</documented>
119119
</location>
120120
</source>
121121
<kind>function</kind>
@@ -148,7 +148,7 @@
148148
<source-path>auto-brief.cpp</source-path>
149149
<line-number>55</line-number>
150150
<column-number>1</column-number>
151-
<documented>1</documented>
151+
<documented>true</documented>
152152
</location>
153153
</source>
154154
<kind>function</kind>
@@ -183,7 +183,7 @@
183183
<source-path>auto-brief.cpp</source-path>
184184
<line-number>104</line-number>
185185
<column-number>1</column-number>
186-
<documented>1</documented>
186+
<documented>true</documented>
187187
</location>
188188
</source>
189189
<kind>function</kind>
@@ -215,7 +215,7 @@
215215
<source-path>auto-brief.cpp</source-path>
216216
<line-number>83</line-number>
217217
<column-number>1</column-number>
218-
<documented>1</documented>
218+
<documented>true</documented>
219219
</location>
220220
</source>
221221
<kind>function</kind>
@@ -247,7 +247,7 @@
247247
<source-path>auto-brief.cpp</source-path>
248248
<line-number>88</line-number>
249249
<column-number>1</column-number>
250-
<documented>1</documented>
250+
<documented>true</documented>
251251
</location>
252252
</source>
253253
<kind>function</kind>
@@ -279,7 +279,7 @@
279279
<source-path>auto-brief.cpp</source-path>
280280
<line-number>93</line-number>
281281
<column-number>1</column-number>
282-
<documented>1</documented>
282+
<documented>true</documented>
283283
</location>
284284
</source>
285285
<kind>function</kind>
@@ -311,7 +311,7 @@
311311
<source-path>auto-brief.cpp</source-path>
312312
<line-number>77</line-number>
313313
<column-number>1</column-number>
314-
<documented>1</documented>
314+
<documented>true</documented>
315315
</location>
316316
</source>
317317
<kind>function</kind>
@@ -343,7 +343,7 @@
343343
<source-path>auto-brief.cpp</source-path>
344344
<line-number>135</line-number>
345345
<column-number>1</column-number>
346-
<documented>1</documented>
346+
<documented>true</documented>
347347
</location>
348348
</source>
349349
<kind>function</kind>
@@ -383,7 +383,7 @@
383383
<source-path>auto-brief.cpp</source-path>
384384
<line-number>120</line-number>
385385
<column-number>1</column-number>
386-
<documented>1</documented>
386+
<documented>true</documented>
387387
</location>
388388
</source>
389389
<kind>function</kind>
@@ -423,7 +423,7 @@
423423
<source-path>auto-brief.cpp</source-path>
424424
<line-number>125</line-number>
425425
<column-number>1</column-number>
426-
<documented>1</documented>
426+
<documented>true</documented>
427427
</location>
428428
</source>
429429
<kind>function</kind>
@@ -463,7 +463,7 @@
463463
<source-path>auto-brief.cpp</source-path>
464464
<line-number>8</line-number>
465465
<column-number>1</column-number>
466-
<documented>1</documented>
466+
<documented>true</documented>
467467
</location>
468468
</source>
469469
<kind>function</kind>
@@ -495,7 +495,7 @@
495495
<source-path>auto-brief.cpp</source-path>
496496
<line-number>17</line-number>
497497
<column-number>1</column-number>
498-
<documented>1</documented>
498+
<documented>true</documented>
499499
</location>
500500
</source>
501501
<kind>function</kind>
@@ -534,7 +534,7 @@
534534
<source-path>auto-brief.cpp</source-path>
535535
<line-number>24</line-number>
536536
<column-number>1</column-number>
537-
<documented>1</documented>
537+
<documented>true</documented>
538538
</location>
539539
</source>
540540
<kind>function</kind>
@@ -573,7 +573,7 @@
573573
<source-path>auto-brief.cpp</source-path>
574574
<line-number>175</line-number>
575575
<column-number>1</column-number>
576-
<documented>1</documented>
576+
<documented>true</documented>
577577
</location>
578578
</source>
579579
<kind>function</kind>
@@ -596,7 +596,7 @@
596596
<source-path>auto-brief.cpp</source-path>
597597
<line-number>165</line-number>
598598
<column-number>1</column-number>
599-
<documented>1</documented>
599+
<documented>true</documented>
600600
</location>
601601
</source>
602602
<kind>function</kind>
@@ -619,7 +619,7 @@
619619
<source-path>auto-brief.cpp</source-path>
620620
<line-number>170</line-number>
621621
<column-number>1</column-number>
622-
<documented>1</documented>
622+
<documented>true</documented>
623623
</location>
624624
</source>
625625
<kind>function</kind>
@@ -642,7 +642,7 @@
642642
<source-path>auto-brief.cpp</source-path>
643643
<line-number>43</line-number>
644644
<column-number>1</column-number>
645-
<documented>1</documented>
645+
<documented>true</documented>
646646
</location>
647647
</source>
648648
<kind>function</kind>
@@ -675,7 +675,7 @@
675675
<source-path>auto-brief.cpp</source-path>
676676
<line-number>65</line-number>
677677
<column-number>1</column-number>
678-
<documented>1</documented>
678+
<documented>true</documented>
679679
</location>
680680
</source>
681681
<kind>function</kind>
@@ -698,7 +698,7 @@
698698
<source-path>auto-brief.cpp</source-path>
699699
<line-number>38</line-number>
700700
<column-number>1</column-number>
701-
<documented>1</documented>
701+
<documented>true</documented>
702702
</location>
703703
</source>
704704
<kind>function</kind>
@@ -721,7 +721,7 @@
721721
<source-path>auto-brief.cpp</source-path>
722722
<line-number>98</line-number>
723723
<column-number>1</column-number>
724-
<documented>1</documented>
724+
<documented>true</documented>
725725
</location>
726726
</source>
727727
<kind>function</kind>
@@ -744,7 +744,7 @@
744744
<source-path>auto-brief.cpp</source-path>
745745
<line-number>115</line-number>
746746
<column-number>1</column-number>
747-
<documented>1</documented>
747+
<documented>true</documented>
748748
</location>
749749
</source>
750750
<kind>function</kind>
@@ -777,7 +777,7 @@
777777
<source-path>auto-brief.cpp</source-path>
778778
<line-number>130</line-number>
779779
<column-number>1</column-number>
780-
<documented>1</documented>
780+
<documented>true</documented>
781781
</location>
782782
</source>
783783
<kind>function</kind>
@@ -800,7 +800,7 @@
800800
<source-path>auto-brief.cpp</source-path>
801801
<line-number>110</line-number>
802802
<column-number>1</column-number>
803-
<documented>1</documented>
803+
<documented>true</documented>
804804
</location>
805805
</source>
806806
<kind>function</kind>
@@ -823,7 +823,7 @@
823823
<source-path>auto-brief.cpp</source-path>
824824
<line-number>143</line-number>
825825
<column-number>1</column-number>
826-
<documented>1</documented>
826+
<documented>true</documented>
827827
</location>
828828
</source>
829829
<kind>function</kind>
@@ -846,7 +846,7 @@
846846
<source-path>auto-brief.cpp</source-path>
847847
<line-number>32</line-number>
848848
<column-number>1</column-number>
849-
<documented>1</documented>
849+
<documented>true</documented>
850850
</location>
851851
</source>
852852
<kind>function</kind>
@@ -907,7 +907,7 @@
907907
<source-path>auto-brief.cpp</source-path>
908908
<line-number>160</line-number>
909909
<column-number>1</column-number>
910-
<documented>1</documented>
910+
<documented>true</documented>
911911
</location>
912912
</source>
913913
<kind>function</kind>
@@ -940,7 +940,7 @@
940940
<source-path>auto-brief.cpp</source-path>
941941
<line-number>150</line-number>
942942
<column-number>1</column-number>
943-
<documented>1</documented>
943+
<documented>true</documented>
944944
</location>
945945
</source>
946946
<kind>function</kind>
@@ -972,7 +972,7 @@
972972
<source-path>auto-brief.cpp</source-path>
973973
<line-number>155</line-number>
974974
<column-number>1</column-number>
975-
<documented>1</documented>
975+
<documented>true</documented>
976976
</location>
977977
</source>
978978
<kind>function</kind>

0 commit comments

Comments
 (0)