fix: reviewer feedback – sparse index default, single sparse ref, clampTopK, keyword_search normalization

Author: clean6378-max-it

src/pinecone-client.ts

@@ -84,6 +84,9 @@ export class PineconeClient {
    * Normalize and clamp topK from request (validates >= 1, caps at MAX_TOP_K).
    */
   private clampTopK(requested: number | undefined): number {
+    if (requested !== undefined && !Number.isFinite(requested)) {
+      throw new Error('topK must be a finite number >= 1');
+    }
     let topK = requested !== undefined ? requested : this.defaultTopK;
     if (topK < 1) {
       throw new Error('topK must be at least 1');
@@ -123,7 +126,7 @@ export class PineconeClient {
 
     const pc = this.ensureClient();
     const denseName = this.indexName;
-    const sparseName = `${this.indexName}-sparse`;
+    const sparseName = this.getSparseIndexName();
 
     const dense = pc.index(denseName) as unknown as SearchableIndex;
     const sparse = pc.index(sparseName) as unknown as SearchableIndex;

src/server/tools/keyword-search-tool.ts

@@ -38,13 +38,23 @@ async function executeKeywordSearch(params: {
 }): Promise<KeywordSearchResponse> {
   const { query_text, namespace, top_k, metadata_filter, fields } = params;
 
-  if (!query_text.trim()) {
+  const normalizedQuery = query_text.trim();
+  const normalizedNamespace = namespace?.trim() ?? '';
+
+  if (!normalizedQuery) {
     return {
       status: 'error',
       message: 'Query text cannot be empty',
     };
   }
 
+  if (!normalizedNamespace) {
+    return {
+      status: 'error',
+      message: 'Namespace cannot be empty',
+    };
+  }
+
   if (metadata_filter) {
     const filterError = validateMetadataFilter(metadata_filter);
     if (filterError) {
@@ -54,19 +64,21 @@ async function executeKeywordSearch(params: {
 
   const client = getPineconeClient();
   const results = await client.keywordSearch({
-    query: query_text.trim(),
-    namespace,
+    query: normalizedQuery,
+    namespace: normalizedNamespace,
     topK: top_k,
     metadataFilter: metadata_filter,
     fields: fields?.length ? fields : undefined,
   });
 
-  const formattedResults = formatQueryResultRows(results, { namespace });
+  const formattedResults = formatQueryResultRows(results, {
+    namespace: normalizedNamespace,
+  });
 
   const response: KeywordSearchResponse = {
     status: 'success',
-    query: query_text,
-    namespace,
+    query: normalizedQuery,
+    namespace: normalizedNamespace,
     index: client.getSparseIndexName(),
     metadata_filter: metadata_filter,
     result_count: formattedResults.length,