Skip to content

Commit 3522e16

Browse files
author
zho
committed
fixed test errors
1 parent d4cca71 commit 3522e16

5 files changed

Lines changed: 9 additions & 11 deletions

File tree

.github/workflows/ci.yml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@ jobs:
1313
strategy:
1414
fail-fast: false
1515
matrix:
16-
node-version: [18.x, 20.x, 22.x]
16+
# Do not add 18.x: Vitest 4 → rolldown imports `styleText` from `node:util` (Node >=20.12 only).
17+
# `@vitest/coverage-v8` needs `node:inspector/promises` (Node >=19). Matches `package.json` engines.
18+
node-version: [20.x, 22.x]
1719

1820
steps:
1921
- uses: actions/checkout@v6
@@ -42,15 +44,9 @@ jobs:
4244
- name: Smoke test CLI
4345
run: node dist/index.js --help
4446

45-
# @vitest/coverage-v8 imports node:inspector/promises (Node 19+). Keep 18.x in the matrix for runtime smoke but skip coverage there.
4647
- name: Run tests with coverage
47-
if: matrix.node-version != '18.x'
4848
run: npm run test:coverage
4949

50-
- name: Run tests (Node 18, no coverage)
51-
if: matrix.node-version == '18.x'
52-
run: npm test
53-
5450
- name: Generate CycloneDX SBOM (lockfile-based)
5551
run: npx --yes @cyclonedx/cyclonedx-npm --package-lock-only --output-file sbom.cdx.json
5652

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Tagged releases are published to npm from GitHub Actions when a **GitHub Release
1717
- `--version` CLI flag prints the package version and exits.
1818
- `list_namespaces` response now includes `expires_at_iso` so clients see the cache expiry as an ISO-8601 timestamp without converting `cache_ttl_seconds`.
1919
- `examples/README.md` describing the library embedding sample.
20-
- GitHub Actions **CI** on **Ubuntu** with a **Node.js** matrix (**18.x**, **20.x**, **22.x**): typecheck, lint, Prettier, build, tests, **CycloneDX** SBOM artifact upload (per Node version), **Codecov** upload (Node **20.x** only), plus a separate **quality** job (`npm audit`, `npm pack --dry-run`).
20+
- GitHub Actions **CI** on **Ubuntu** with a **Node.js** matrix (**20.x**, **22.x**): typecheck, lint, Prettier, build, `test:coverage`, **CycloneDX** SBOM artifact upload (per Node version), **Codecov** upload (Node **20.x** only), plus a separate **quality** job (`npm audit`, `npm pack --dry-run`).
2121
- `npm run test:coverage` with Vitest coverage thresholds (see `vitest.config.ts`).
2222
- `@vitest/coverage-v8` devDependency for coverage reports (`lcov`, `json-summary`, HTML).
2323

@@ -34,7 +34,7 @@ Tagged releases are published to npm from GitHub Actions when a **GitHub Release
3434
- README Slack URL example now matches the generator output (`https://app.slack.com/client/{team_id}/{channel_id}/p{messageId}`).
3535
- README "Comparison with Python Version" no longer claims an identical API interface; the new TypeScript-only tools (`guided_query`, `query_documents`, `keyword_search`, `namespace_router`, `suggest_query_params`, `count`, `generate_urls`) are listed explicitly.
3636
- `npm run ci` now runs `test:coverage` so merges are gated on coverage thresholds.
37-
- CI: on Node **18.x**, run `npm test` only; **`test:coverage`** runs on **20.x** / **22.x** because Vitest V8 coverage uses `node:inspector/promises` (Node **≥19**).
37+
- **Breaking (runtime / tooling):** `engines.node` is now **>=20.12.0**. Vitest **4** (bundled **rolldown**) imports `util.styleText` from `node:util` (added in Node **20.12**), and **`@vitest/coverage-v8`** uses `node:inspector/promises` (Node **≥19**). CI tests only **20.x** and **22.x**.
3838
- Dependabot groups related **vitest**, **typescript-eslint**, and **eslint/prettier** updates.
3939

4040
### Removed

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ A Model Context Protocol (MCP) server that provides semantic search over Pinecon
3333

3434
## Installation
3535

36+
**Node.js [20.12](https://nodejs.org/en/download) or later** is required (`engines` in `package.json`).
37+
3638
### As a Package
3739

3840
```bash

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
},
4343
"homepage": "https://github.com/CppDigest/pinecone-read-only-mcp-typescript#readme",
4444
"engines": {
45-
"node": ">=18.0.0"
45+
"node": ">=20.12.0"
4646
},
4747
"scripts": {
4848
"clean": "node -e \"const fs=require('fs'); fs.rmSync('dist',{recursive:true,force:true});\"",

0 commit comments

Comments
 (0)