fix: address CodeRabbit feedback (Prettier, response.index, clampTopK, test summary)

fix: address CodeRabbit feedback for keyword_search and tooling

- Prettier: format keyword-search-tool.ts and index.ts
- response.index: add getSparseIndexName() on PineconeClient; use in keyword_search
- pinecone-client: extract clampTopK(), use in query() and keywordSearch()
- keyword-search-tool: remove redundant top_k ?? 10 (Zod default)
- test-search: add Test 5 timing to performance summary (duration5 / skipped)

Author: clean6378-max-it

scripts/test-search.ts

@@ -153,6 +153,8 @@ async function test() {
     }
 
     // Test 5: Keyword (sparse-only) search on pinecone-rag-sparse
+    let duration5: number | undefined;
+    let test5Skipped = false;
     console.log(`\n🔤 Test 5: Keyword search (sparse-only index)`);
     console.log(`   Namespace: "${testNamespace}"`);
     console.log(`   Query: "test query"`);
@@ -164,14 +166,21 @@ async function test() {
         namespace: testNamespace,
         topK: 3,
       });
-      const duration5 = Date.now() - startTime5;
+      duration5 = Date.now() - startTime5;
       console.log(`✅ Keyword search returned ${results5.length} result(s) in ${duration5}ms`);
       if (results5.length > 0) {
-        console.log(`   First result score: ${results5[0].score.toFixed(4)}, reranked: ${results5[0].reranked}`);
+        console.log(
+          `   First result score: ${results5[0].score.toFixed(4)}, reranked: ${results5[0].reranked}`
+        );
       }
     } catch (kwError) {
-      console.log(`⚠️  Keyword search skipped: ${kwError instanceof Error ? kwError.message : String(kwError)}`);
-      console.log(`   Ensure PINECONE_SPARSE_INDEX_NAME (e.g. pinecone-rag-sparse) exists and has data.`);
+      test5Skipped = true;
+      console.log(
+        `⚠️  Keyword search skipped: ${kwError instanceof Error ? kwError.message : String(kwError)}`
+      );
+      console.log(
+        `   Ensure PINECONE_SPARSE_INDEX_NAME (e.g. pinecone-rag-sparse) exists and has data.`
+      );
     }
 
     console.log('\n✨ All tests completed successfully!');
@@ -181,6 +190,11 @@ async function test() {
     if (duration3 !== undefined) {
       console.log(`  With metadata filter: ${duration3}ms`);
     }
+    if (duration5 !== undefined) {
+      console.log(`  Keyword search:       ${duration5}ms`);
+    } else if (test5Skipped) {
+      console.log(`  Keyword search:       skipped`);
+    }
     console.log(`  Reranking overhead:   ${duration2 - duration1}ms`);
   } catch (error) {
     console.error('\n❌ Error during testing:', error);

src/index.ts

@@ -11,7 +11,11 @@
 import { StdioServerTransport } from '@modelcontextprotocol/sdk/server/stdio.js';
 import { PineconeClient } from './pinecone-client.js';
 import { setupServer, setPineconeClient } from './server.js';
-import { DEFAULT_INDEX_NAME, DEFAULT_RERANK_MODEL, DEFAULT_SPARSE_INDEX_NAME } from './constants.js';
+import {
+  DEFAULT_INDEX_NAME,
+  DEFAULT_RERANK_MODEL,
+  DEFAULT_SPARSE_INDEX_NAME,
+} from './constants.js';
 import type { LogLevel } from './config.js';
 import { setLogLevel } from './logger.js';
 import * as dotenv from 'dotenv';

src/pinecone-client.ts

@@ -82,6 +82,25 @@ export class PineconeClient {
       config.defaultTopK || parseInt(process.env['PINECONE_TOP_K'] || String(DEFAULT_TOP_K));
   }
 
+  /** Returns the configured sparse index name used for keyword search (runtime value). */
+  getSparseIndexName(): string {
+    return this.sparseIndexName;
+  }
+
+  /**
+   * Normalize and clamp topK from request (validates >= 1, caps at MAX_TOP_K).
+   */
+  private clampTopK(requested: number | undefined): number {
+    let topK = requested !== undefined ? requested : this.defaultTopK;
+    if (topK < 1) {
+      throw new Error('topK must be at least 1');
+    }
+    if (topK > MAX_TOP_K) {
+      topK = MAX_TOP_K;
+    }
+    return topK;
+  }
+
   /**
    * Ensure Pinecone client is initialized
    */
@@ -413,14 +432,7 @@ export class PineconeClient {
       throw new Error('Query cannot be empty');
     }
 
-    let topK = requestedTopK !== undefined ? requestedTopK : this.defaultTopK;
-    if (topK < 1) {
-      throw new Error('topK must be at least 1');
-    }
-
-    if (topK > MAX_TOP_K) {
-      topK = MAX_TOP_K;
-    }
+    const topK = this.clampTopK(requestedTopK);
 
     // When reranking, Pinecone requires chunk_text in returned fields; add it if user specified fields without it
     const searchFields =
@@ -494,13 +506,7 @@ export class PineconeClient {
       throw new Error('Query cannot be empty');
     }
 
-    let topK = requestedTopK !== undefined ? requestedTopK : this.defaultTopK;
-    if (topK < 1) {
-      throw new Error('topK must be at least 1');
-    }
-    if (topK > MAX_TOP_K) {
-      topK = MAX_TOP_K;
-    }
+    const topK = this.clampTopK(requestedTopK);
 
     const keywordIndex = await this.ensureKeywordIndex();
     const searchOptions = requestedFields?.length ? { fields: requestedFields } : undefined;

src/server/tools/keyword-search-tool.ts

@@ -1,6 +1,6 @@
 import type { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js';
 import { z } from 'zod';
-import { DEFAULT_SPARSE_INDEX_NAME, MAX_TOP_K, MIN_TOP_K } from '../../constants.js';
+import { MAX_TOP_K, MIN_TOP_K } from '../../constants.js';
 import { getPineconeClient } from '../client-context.js';
 import { formatQueryResultRows } from '../format-query-result.js';
 import { metadataFilterSchema, validateMetadataFilter } from '../metadata-filter.js';
@@ -67,7 +67,7 @@ async function executeKeywordSearch(params: {
     status: 'success',
     query: query_text,
     namespace,
-    index: DEFAULT_SPARSE_INDEX_NAME,
+    index: client.getSparseIndexName(),
     metadata_filter: metadata_filter,
     result_count: formattedResults.length,
     results: formattedResults,
@@ -91,9 +91,7 @@ export function registerKeywordSearchTool(server: McpServer): void {
         query_text: z.string().describe('Search query text (keyword/lexical match).'),
         namespace: z
           .string()
-          .describe(
-            'Namespace to search. Use list_namespaces to discover available namespaces.'
-          ),
+          .describe('Namespace to search. Use list_namespaces to discover available namespaces.'),
         top_k: z
           .number()
           .int()
@@ -117,7 +115,7 @@ export function registerKeywordSearchTool(server: McpServer): void {
         const response = await executeKeywordSearch({
           query_text: params.query_text,
           namespace: params.namespace,
-          top_k: params.top_k ?? 10,
+          top_k: params.top_k,
           metadata_filter: params.metadata_filter,
           fields: params.fields,
         });