#15-fix second errors

Author: zho

package.json

@@ -37,7 +37,7 @@
   },
   "scripts": {
     "clean": "node -e \"const fs=require('fs'); fs.rmSync('dist',{recursive:true,force:true});\"",
-    "build": "npm run clean && node ./node_modules/typescript/bin/tsc",
+    "build": "npm run clean && npx tsc",
     "build:watch": "tsc --watch",
     "dev": "tsx watch src/index.ts",
     "start": "node dist/index.js",
@@ -52,7 +52,7 @@
     "format:check": "prettier --check \"src/**/*.ts\" \"*.json\" \".prettierrc\"",
     "typecheck": "tsc --noEmit",
     "ci": "npm run typecheck && npm run lint && npm run format:check && npm run build && npm test",
-    "release:check": "npm run ci && npm pack --dry-run",
+    "release:check": "npm run ci && npm pack --dry-run --ignore-scripts",
     "ci:local": "bash scripts/ci-local.sh",
     "prepublishOnly": "npm run ci",
     "prepack": "npm run build"

src/index.ts

@@ -105,12 +105,10 @@ async function main(): Promise<void> {
     const rawLevel =
       options.logLevel ||
       process.env['PINECONE_READ_ONLY_MCP_LOG_LEVEL'] ||
-      process.env['LOG_LEVEL'] ||
       'INFO';
     const logLevel = (
       ['DEBUG', 'INFO', 'WARN', 'ERROR'].includes(rawLevel) ? rawLevel : 'INFO'
     ) as LogLevel;
-    process.env['LOG_LEVEL'] = logLevel;
     setLogLevel(logLevel);
 
     // Get API key

src/logger.ts

@@ -30,11 +30,17 @@ function shouldLog(level: LogLevel): boolean {
 }
 
 /** Format a single log line: timestamp, level, message, and optional JSON data. */
-function formatMessage(level: string, msg: string, data?: unknown): string {
+function formatMessage(level: LogLevel, msg: string, data?: unknown): string {
   const ts = new Date().toISOString();
   const prefix = `[${ts}] [${level}]`;
   if (data !== undefined) {
-    return `${prefix} ${msg} ${JSON.stringify(data)}`;
+    let serialized: string;
+    try {
+      serialized = JSON.stringify(data);
+    } catch {
+      serialized = String(data);
+    }
+    return `${prefix} ${msg} ${serialized}`;
   }
   return `${prefix} ${msg}`;
 }
@@ -63,10 +69,6 @@ export function warn(msg: string, data?: unknown): void {
 /** Log an ERROR-level message to stderr with optional error (message and stack). */
 export function error(msg: string, err?: unknown): void {
   if (shouldLog('ERROR')) {
-    // const detail = err instanceof Error ? err.message : err !== undefined ? String(err) : undefined;
-    // console.error(
-    //   formatMessage('ERROR', msg, detail !== undefined ? { error: detail } : undefined)
-    // );
     const detail =
       err instanceof Error
         ? { message: err.message, stack: err.stack }

src/pinecone-client.ts

@@ -168,7 +168,7 @@ export class PineconeClient {
                         if (!(key in metadataFields)) {
                           metadataFields[key] = inferredType;
                         } else if (
-                          metadataFields[key] === 'object' &&
+                          metadataFields[key] === 'object' || metadataFields[key] === 'array' &&
                           inferredType === 'string[]'
                         ) {
                           // Prefer array type over generic object when we see it in another sample
@@ -227,9 +227,7 @@ export class PineconeClient {
     // Include filter when explicitly provided (matches Python behavior).
     if (metadataFilter !== undefined) {
       queryPayload['filter'] = metadataFilter;
-      if (!options?.fields) {
-        logDebug('Applying metadata filter', metadataFilter);
-      }
+      logDebug('Applying metadata filter', metadataFilter);
     }
 
     try {

src/server/format-query-result.ts

@@ -46,8 +46,10 @@ export function formatSearchResultAsRow(
   const docNum = metadata['document_number'];
   const filename = metadata['filename'];
   const paper_number =
-    (typeof docNum === 'string' ? docNum : null) ??
-    (typeof filename === 'string' ? filename.replace(/\.md$/i, '').toUpperCase() : null) ??
+    (typeof docNum === 'string' && docNum.length > 0 ? docNum : null) ??
+    (typeof filename === 'string' && filename.length > 0
+      ? filename.replace(/\.md$/i, '').toUpperCase()
+      : null) ??
     null;
 
   return {

src/server/tools/count-tool.ts

@@ -9,7 +9,7 @@ import { jsonErrorResponse, jsonResponse } from '../tool-response.js';
 const COUNT_RESPONSE_STATUS = 'success' as const;
 type CountResponse =
   | {
-      status: typeof COUNT_RESPONSE_STATUS;
+      status: 'success';
       count: number;
       truncated: boolean;
       namespace: string;
@@ -78,7 +78,7 @@ export function registerCountTool(server: McpServer): void {
           count,
           truncated,
           namespace,
-          metadata_filter: metadata_filter,
+          metadata_filter,
         };
         return jsonResponse(response);
       } catch (error) {

src/server/tools/generate-urls-tool.ts

@@ -29,6 +29,7 @@ export function registerGenerateUrlsTool(server: McpServer): void {
           ),
         records: z
           .array(z.record(z.string(), z.unknown()))
+          .max(500)
           .describe(
             'Array of records from retrieval results. Each item may be either metadata itself or an object containing a metadata field.'
           ),

src/server/tools/query-documents-tool.ts

@@ -111,7 +111,7 @@ export function registerQueryDocumentsTool(server: McpServer): void {
           status: 'success',
           query: query_text.trim(),
           namespace,
-          metadata_filter: metadata_filter ?? undefined,
+          metadata_filter,
           result_count: topDocuments.length,
           documents: topDocuments.map((doc) => ({
             document_id: doc.document_id,

src/server/tools/query-tool.ts

@@ -25,7 +25,7 @@ type QueryExecParams = {
 async function executeQuery(params: QueryExecParams) {
   const { query_text, namespace, top_k, use_reranking, metadata_filter, fields, mode } = params;
   try {
-    if (!query_text || !query_text.trim()) {
+    if (!query_text.trim()) {
       const response: QueryResponse = {
         status: 'error',
         message: 'Query text cannot be empty',
@@ -128,8 +128,8 @@ export function registerQueryTool(server: McpServer): void {
     async (params) =>
       executeQuery({
         ...params,
-        top_k: params.top_k ?? 10,
-        use_reranking: params.use_reranking ?? true,
+        top_k: params.top_k,
+        use_reranking: params.use_reranking,
         mode: 'query',
       })
   );
@@ -147,7 +147,7 @@ export function registerQueryTool(server: McpServer): void {
     async (params) =>
       executeQuery({
         ...params,
-        top_k: params.top_k ?? 10,
+        top_k: params.top_k,
         use_reranking: false,
         fields: params.fields?.length ? params.fields : [...FAST_QUERY_FIELDS],
         mode: 'query_fast',