#15-fix validation logic for array type

Author: zho

src/server/metadata-filter.ts

@@ -30,9 +30,9 @@ function isPrimitiveFilterValue(value: unknown): boolean {
   return typeof value === 'string' || typeof value === 'number' || typeof value === 'boolean';
 }
 
-/** True if value is an array of primitives (required for $in/$nin). */
+/** True if value is an array of string (required for $in/$nin). */
 function isPrimitiveArray(value: unknown): boolean {
-  return Array.isArray(value) && value.every((item) => isPrimitiveFilterValue(item));
+  return Array.isArray(value) && value.every((item) => typeof item === 'string');
 }
 
 /** Recursively validate a filter value; returns an error string or null if valid. */
@@ -50,25 +50,27 @@ function validateMetadataFilterValue(value: unknown, path: string[]): string | n
   }
 
   for (const [key, nestedValue] of Object.entries(value)) {
-    if (key.startsWith('$')) {
-      if (!ALLOWED_FILTER_OPERATORS.has(key)) {
-        return `Unsupported filter operator "${key}" at "${path.join('.')}".`;
-      }
-      if ((key === '$in' || key === '$nin') && !isPrimitiveArray(nestedValue)) {
-        return `Operator "${key}" at "${path.join('.')}" must use an array of primitive values.`;
-      }
-      if (
-        (key === '$eq' ||
-          key === '$ne' ||
-          key === '$gt' ||
-          key === '$gte' ||
-          key === '$lt' ||
-          key === '$lte') &&
-        !isPrimitiveFilterValue(nestedValue)
-      ) {
-        return `Operator "${key}" at "${path.join('.')}" must use a primitive value.`;
-      }
+    if (!key.startsWith('$')) {
+      return `Unsupported filter operator "${key}" at "${path.join('.')}".`;
     }
+    if (!ALLOWED_FILTER_OPERATORS.has(key)) {
+      return `Unsupported filter operator "${key}" at "${path.join('.')}".`;
+    }
+    if ((key === '$in' || key === '$nin') && !isPrimitiveArray(nestedValue)) {
+      return `Operator "${key}" at "${path.join('.')}" must use an array of primitive values.`;
+    }
+    if (
+      (key === '$eq' ||
+        key === '$ne' ||
+        key === '$gt' ||
+        key === '$gte' ||
+        key === '$lt' ||
+        key === '$lte') &&
+      !isPrimitiveFilterValue(nestedValue)
+    ) {
+      return `Operator "${key}" at "${path.join('.')}" must use a primitive value.`;
+    }
+
 
     const nestedError = validateMetadataFilterValue(nestedValue, [...path, key]);
     if (nestedError) {

src/server/namespace-router.ts

@@ -56,6 +56,7 @@ export function rankNamespacesByQuery(
   namespaces: NamespaceInfo[],
   topN: number
 ): RankedNamespace[] {
+  const limit = Math.max(1, Math.floor(topN));
   return namespaces
     .map((ns) => {
       const fields = Object.keys(ns.metadata ?? {});
@@ -73,5 +74,5 @@ export function rankNamespacesByQuery(
       // targeted namespaces are chosen over large catch-all ones.
       return a.record_count - b.record_count;
     })
-    .slice(0, topN);
+    .slice(0, limit);
 }

src/server/url-generation.ts

@@ -30,7 +30,7 @@ function generatorMailing(metadata: Record<string, unknown>): UrlGenerationResul
     };
   }
   return {
-    url: `https://lists.boost.org/archives/list/${docIdOrThread}/`,
+    url: `https://lists.boost.org/archives/list/${encodeURIComponent(docIdOrThread)}/`,
     method: 'generated.mailing',
   };
 }