#15-fix for review

Author: zho

src/server/tools/count-tool.ts

@@ -23,10 +23,10 @@ export function registerCountTool(server: McpServer): void {
     'count',
     {
       description:
-        'Get the count of unique documents matching a metadata filter and semantic query. ' +
-        'Use when the user asks for a count (e.g. "how many papers by Lakos?", "Lakos\'s paper count"). ' +
+        'Get the number of unique documents matching a metadata filter and semantic query. ' +
+        'Use when the user asks for a count (e.g. "how many papers by J. Lakos?", "John\'s paper count"). ' +
         'Uses semantic (dense) search only and requests only document identifiers (no content) for performance. ' +
-        'Returns unique document count (deduped by document_number/url/doc_id) up to 10,000; truncated=true if at least that many. ' +
+        'Returns the number of unique documents (deduped by document_number/url/doc_id) up to 10,000; truncated=true if at least that many. ' +
         'Mandatory flow: call suggest_query_params first, then count. ' +
         'Use list_namespaces to discover namespace and metadata fields. ' +
         'For count-by-metadata only, use a broad query_text (e.g. "paper" or "document"). ' +
@@ -43,7 +43,7 @@ export function registerCountTool(server: McpServer): void {
         metadata_filter: metadataFilterSchema
           .optional()
           .describe(
-            'Optional metadata filter. Use exact field names from list_namespaces. E.g. {"author": {"$in": ["John Lakos"]}} for author count.'
+            'Optional metadata filter. Use exact field names from list_namespaces. E.g. {"author": {"$in": ["John Lakos", "J. Lakos"]}} for author count.'
           ),
       },
     },

src/server/url-generation.test.ts

@@ -31,6 +31,39 @@ describe('generateUrlForNamespace', () => {
     expect(r.method).toBe('generated.mailing');
   });
 
+  it('generates mailing URL as list_name/message/doc_id when list_name present and doc_id does not contain it', () => {
+    const r = generateUrlForNamespace('mailing', {
+      list_name: 'boost-users',
+      doc_id: '12345',
+    });
+    expect(r.url).toBe(
+      'https://lists.boost.org/archives/list/boost-users/message/12345/'
+    );
+    expect(r.method).toBe('generated.mailing');
+  });
+
+  it('uses msg_id when list_name present and doc_id missing', () => {
+    const r = generateUrlForNamespace('mailing', {
+      list_name: 'boost-announce',
+      msg_id: '67890',
+    });
+    expect(r.url).toBe(
+      'https://lists.boost.org/archives/list/boost-announce/message/67890/'
+    );
+    expect(r.method).toBe('generated.mailing');
+  });
+
+  it('uses single-path form when doc_id contains list_name (no list_name/message split)', () => {
+    const r = generateUrlForNamespace('mailing', {
+      list_name: 'boost-users',
+      doc_id: 'boost-users@lists.boost.org/message/12345',
+    });
+    expect(r.url).toBe(
+      'https://lists.boost.org/archives/list/boost-users@lists.boost.org/message/12345/'
+    );
+    expect(r.method).toBe('generated.mailing');
+  });
+
   it('uses slack source when available', () => {
     const r = generateUrlForNamespace('slack-Cpplang', {
       source: 'https://app.slack.com/client/T123/C123/p123',

src/server/url-generation.ts

@@ -19,14 +19,31 @@ function asString(value: unknown): string | null {
   return typeof value === 'string' && value.trim().length > 0 ? value.trim() : null;
 }
 
-/** Build a mailing-list URL from doc_id or thread_id (e.g. Boost archives). */
+/**
+ * Build a mailing-list URL (e.g. Boost archives).
+ * Two cases:
+ * 1. If metadata has list_name and doc_id (or msg_id) and the message id does not contain list_name,
+ *    URL is https://lists.boost.org/archives/list/{list_name}/message/{doc_id}/
+ * 2. Otherwise use doc_id or thread_id as the list path: .../list/{doc_id_or_thread_id}/
+ */
 function generatorMailing(metadata: Record<string, unknown>): UrlGenerationResult {
-  const docIdOrThread = asString(metadata['doc_id']) ?? asString(metadata['thread_id']);
+  const listName = asString(metadata['list_name']);
+  const docId = asString(metadata['doc_id']) ?? asString(metadata['msg_id']);
+  const threadId = asString(metadata['thread_id']);
+
+  if (listName && docId && !docId.includes(listName)) {
+    return {
+      url: `https://lists.boost.org/archives/list/${listName}/message/${docId}/`,
+      method: 'generated.mailing',
+    };
+  }
+
+  const docIdOrThread = docId ?? threadId;
   if (!docIdOrThread) {
     return {
       url: null,
       method: 'unavailable',
-      reason: 'mailing requires doc_id or thread_id to generate URL',
+      reason: 'mailing requires doc_id, msg_id, or thread_id to generate URL',
     };
   }
   return {
@@ -85,8 +102,3 @@ export function generateUrlForNamespace(
     reason: `URL generation is not supported for namespace "${namespace}"`,
   };
 }
-
-/** Register a URL generator for a namespace (e.g. for custom indexes). */
-export function registerUrlGenerator(namespace: string, fn: UrlGenerator): void {
-  urlGenerators.set(namespace, fn);
-}