feat: phase 1 export trim — remove experimental block builders from public API - #166
Conversation
…ublic API Remove buildQueryExperimental and buildGuidedQueryExperimental from package root and /alliance re-exports. PineconeClient return types and Zod response schemas remain public. Add MIGRATION.md guidance, CHANGELOG entry, and export-surface regression test. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughRemoves ChangesExperimental Builder Export Removal
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
=======================================
Coverage ? 87.56%
=======================================
Files ? 40
Lines ? 1664
Branches ? 554
=======================================
Hits ? 1457
Misses ? 207
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@coderabbitai full review again |
|
✅ Action performedFull review finished. |
Summary
Remove internal experimental-block assembly helpers from the public package surface.
@will-cppa/pinecone-read-only-mcpand/alliancere-exports:buildQueryExperimental,buildGuidedQueryExperimental../response-schemas.js(no runtime behavior change)src/core/__tests__/public-exports.test.tsregression guard,CHANGELOG.md[Unreleased]entries,docs/MIGRATION.md#unreleased-trimmed-library-exportsTest plan
npm run release:check(typecheck, lint, format, build, coverage, pack dry-run)npm test— 264 tests passed, includingpublic-exports.test.tsnpm pack --dry-run— builders absent from publishedindex.d.tsRelated Issue
Summary by CodeRabbit
Breaking Changes
buildQueryExperimentalandbuildGuidedQueryExperimentalfrom the public library exports (including the/alliancesurface).Documentation
CHANGELOG.mdwith Unreleased breaking notes.Tests