fix(2447): clear errors after successful AJAX submission, remove override author email checkbox

Author: ycanales

templates/v3/user_profile_edit.html

@@ -203,7 +203,6 @@
             {% include 'v3/includes/_field_combo.html' with name=user_profile_form.country.name label='Country' options=country_options selected=user_profile_form.country.value placeholder='Select' error=user_profile_form.country.errors.0 %}
             {% include 'v3/includes/_field_include.html' with bound_field=user_profile_form.indicate_last_login_method %}
             {% include 'v3/includes/_field_include.html' with bound_field=user_profile_form.override_commit_author_name %}
-            {% include 'v3/includes/_field_include.html' with bound_field=user_profile_form.override_commit_author_email %}
           </div>
           <hr class="card__hr" aria-hidden="true" />
           <div class="card__cta_section">
@@ -349,6 +348,15 @@
             if (response.ok && contentType.includes('application/json')) {
               this.saved = true
               succeeded = true
+              // Static, server-rendered field errors (left over from a prior
+              // failed submit) don't clear themselves on a successful AJAX
+              // save since they aren't Alpine-reactive. Clear them here.
+              form.querySelectorAll('.field--error').forEach((wrapper) => {
+                wrapper.classList.remove('field--error')
+              })
+              form.querySelectorAll('p.field__error:not([x-show])').forEach((el) => {
+                el.remove()
+              })
             }
           } catch (_) {}
           if (!succeeded) {

users/forms.py

@@ -339,10 +339,6 @@ def clean_username(self):
         help_text="Globally replaces your git commit author name with username value set above",
         required=False,
     )
-    override_commit_author_email = forms.BooleanField(
-        help_text="Links your login to an existing commit-author email after verification",
-        required=False,
-    )
 
     # Commit Emails
     commit_email_formset = V3CommitEmailFormSet(