fix(2397): reset approval state when updating what's new

Author: ycanales

versions/management/commands/generate_whats_new.py

@@ -81,7 +81,7 @@ def command(
         click.secho(f"queueing whats_new for {version.name}", fg="green")
         if force:
             Version.objects.filter(pk=version.pk).update(
-                whats_new="", whats_new_html=""
+                whats_new="", whats_new_html="", whats_new_approved=False
             )
         dispatch_whats_new(version.pk)
 

versions/tasks.py

@@ -727,7 +727,11 @@ def generate_whats_new(self, version_pk: int) -> str | None:
 
 @app.task
 def save_whats_new(markdown_text: str | None, version_pk: int):
-    """Persist a generated summary on the Version. Approval is left untouched."""
+    """Persist a generated summary on the Version.
+
+    Resets ``whats_new_approved`` to False so regenerated content goes back
+    through admin moderation before it becomes visible on the public site.
+    """
     from core.htmlhelper import render_whats_new_markdown
 
     if not markdown_text:
@@ -738,6 +742,7 @@ def save_whats_new(markdown_text: str | None, version_pk: int):
         whats_new=markdown_text,
         whats_new_html=render_whats_new_markdown(markdown_text),
         whats_new_generated_at=timezone.now(),
+        whats_new_approved=False,
     )
     logger.info("save_whats_new_saved", version_pk=version_pk)
 

versions/tests/test_ai_tasks.py

@@ -96,12 +96,12 @@ def test_save_whats_new_sanitizes_html(version):
 
 
 @pytest.mark.django_db
-def test_save_whats_new_does_not_change_approval(version):
+def test_save_whats_new_resets_approval(version):
     Version.objects.filter(pk=version.pk).update(whats_new_approved=True)
     save_whats_new.run(SAMPLE_OUTPUT, version.pk)
 
     version.refresh_from_db()
-    assert version.whats_new_approved is True
+    assert version.whats_new_approved is False
 
 
 @pytest.mark.django_db