Skip to content

Commit 3991e68

Browse files
committed
fix(2285): move star next to name in user profile
1 parent cc145d4 commit 3991e68

3 files changed

Lines changed: 23 additions & 13 deletions

File tree

core/views.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1798,7 +1798,6 @@ def get_context_data(self, **kwargs):
17981798
"role": "Maintainer",
17991799
"avatar_url": f"{settings.STATIC_URL}img/v3/demo_page/Avatar.png",
18001800
"badge": BadgeToken.STAR_TIER_5,
1801-
"achievement_count": 22,
18021801
"bio": "",
18031802
},
18041803
{
@@ -1807,7 +1806,6 @@ def get_context_data(self, **kwargs):
18071806
"role": "Author",
18081807
"avatar_url": f"{settings.STATIC_URL}img/v3/demo_page/Avatar.png",
18091808
"badge": BadgeToken.BOOST_DAY,
1810-
"achievement_count": 7,
18111809
"bio": "Boost Day contributor.",
18121810
},
18131811
]

static/css/v3/user-profile.css

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,14 @@
3333

3434
/* ── Header: flex row with wrap ─────────────── */
3535
/*
36-
Default (no bio): name takes full width,
36+
Default (no bio): the name group takes full width,
3737
forcing role + badge to wrap onto a second line.
3838
39-
With bio: name shrinks to fit-content,
39+
With bio: the name group shrinks to fit-content,
4040
so all items sit inline on one row.
41+
42+
The name group keeps the name and any star badge together,
43+
so the star always stays next to the name.
4144
*/
4245

4346
.user-profile__header {
@@ -48,11 +51,15 @@
4851
row-gap: var(--space-s);
4952
}
5053

51-
.user-profile__name {
54+
.user-profile__name-group {
55+
display: inline-flex;
56+
align-items: center;
57+
gap: var(--space-default);
58+
min-width: 0;
5259
width: 100%;
5360
}
5461

55-
.user-profile--has-bio .user-profile__name {
62+
.user-profile--has-bio .user-profile__name-group {
5663
width: auto;
5764
}
5865

templates/v3/includes/_user_profile.html

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,22 @@
2525

2626
<div class="user-profile__content">
2727
<div class="user-profile__header">
28-
{% if author.name %}
29-
{% if author.profile_url %}
30-
<a href="{{ author.profile_url }}" class="user-profile__name">{{ author.name }}</a>
31-
{% else %}
32-
<span class="user-profile__name">{{ author.name }}</span>
28+
<span class="user-profile__name-group">
29+
{% if author.name %}
30+
{% if author.profile_url %}
31+
<a href="{{ author.profile_url }}" class="user-profile__name">{{ author.name }}</a>
32+
{% else %}
33+
<span class="user-profile__name">{{ author.name }}</span>
34+
{% endif %}
3335
{% endif %}
34-
{% endif %}
36+
{% if author.badge|slice:":5" == "star-" %}
37+
{% include "v3/includes/_badge_v3.html" with token=author.badge label=author.badge_label size="small" only %}
38+
{% endif %}
39+
</span>
3540
{% if author.role %}
3641
<span class="user-profile__role">{{ author.role }}</span>
3742
{% endif %}
38-
{% if author.badge %}
43+
{% if author.badge and author.badge|slice:":5" != "star-" %}
3944
{% include "v3/includes/_badge_v3.html" with token=author.badge label=author.badge_label size="small" only %}
4045
{% endif %}
4146
{% if author.achievement_count %}

0 commit comments

Comments
 (0)