Skip to content

Commit 638c7bf

Browse files
committed
QA Feedback: Add icon to community card
1 parent d8acfd1 commit 638c7bf

5 files changed

Lines changed: 17 additions & 9 deletions

File tree

static/css/v3/community-card.css

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,13 @@
44
*/
55

66
.community-card .content-detail-icon {
7-
border: none;
8-
gap: var(--space-medium);
7+
border: none;
8+
gap: var(--space-medium);
9+
}
10+
11+
.community-card .content-detail-icon__icon {
12+
color: var(--color-text-primary);
13+
914
}
1015

1116
.community-card .content-detail-icon__cta {

static/css/v3/content.css

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ a:hover .content-detail-icon:not(.content-detail-icon--contained) {
3535
display: flex;
3636
align-items: center;
3737
justify-content: center;
38-
width: var(--space-card);
39-
height: var(--space-card);
38+
width: var(--space-xlarge);
39+
height: var(--space-xlarge);
4040
transition: color 0.2s ease;
4141
}
4242

@@ -46,8 +46,6 @@ a:hover .content-detail-icon:not(.content-detail-icon--contained) {
4646
}
4747

4848
.content-detail-icon__icon svg {
49-
width: 100%;
50-
height: 100%;
5149
display: block;
5250
}
5351

@@ -66,7 +64,7 @@ a:hover .content-detail-icon:not(.content-detail-icon--contained) {
6664

6765
.content-detail-icon--has-icon .content-detail-icon__title,
6866
.content-detail-icon--has-badge .content-detail-icon__title {
69-
padding-right: var(--space-icon-offset);
67+
padding-right: var(--space-xlarge);
7068
}
7169

7270
.content-detail-icon__title-link {

templates/includes/icon.html

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,10 @@
4343
<svg class="{{ icon_class|default:'icon' }}" width="{{ icon_size|default:24 }}" height="{{ icon_size|default:24 }}" viewBox="0 0 16 16" fill="currentColor" xmlns="http://www.w3.org/2000/svg" aria-hidden="true">
4444
<path d="M7.6639 12.3332H6.33057L6.32997 13.5H5V2.5H6.32997L6.33057 3.66657H7.6639V4.9999H8.99724V5.9999H10.3306V7.33324H11.6639V8.66657H10.3306V9.9999H8.99724V10.9999H7.6639V12.3332Z" fill="#050816"/>
4545
</svg>
46+
{% elif icon_name == "bullseye-pixel" %}
47+
<svg class="{{ icon_class|default:'icon' }}" width="{{ icon_size|default:24 }}" height="{{ icon_size|default:24 }}" viewBox="0 0 16 16" fill="currentColor" xmlns="http://www.w3.org/2000/svg" aria-hidden="true">
48+
<path d="M3.99992 1.33337H10.6666V2.66671H3.99992V1.33337ZM2.66659 4.00004V2.66671H3.99992V4.00004H2.66659ZM2.66659 12H1.33325V4.00004H2.66659V12ZM3.99992 13.3334H2.66659V12H3.99992V13.3334ZM11.9999 13.3334H3.99992V14.6667H11.9999V13.3334ZM13.3333 12V13.3334H11.9999V12H13.3333ZM13.3333 12H14.6666V5.33337H13.3333V12ZM7.99992 4.00004H5.33325V5.33337H3.99992V10.6667H5.33325V12H10.6666V10.6667H11.9999V8.00004H10.6666V10.6667H5.33325V5.33337H7.99992V4.00004ZM9.33325 9.33337V6.66671H10.6666V5.33337H11.9999V4.00004H14.6666V2.66671H13.3333V1.33337H11.9999V4.00004H10.6666V5.33337H9.33325V6.66671H6.66658V9.33337H9.33325Z" />
49+
</svg>
4650
{% else %}
4751
<svg class="{{ icon_class|default:'icon' }}"
4852
width="{{ icon_size|default:24 }}"

templates/v3/includes/_community_card.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
<ul class="card-group__list">
2828
{% for item in items %}
2929
<li class="card-group__item community-card">
30-
{% include 'v3/includes/_content_detail_card_item.html' with title=item.title description=item.description cta_href=item.cta_url cta_label=item.cta_label only %}
30+
{% include 'v3/includes/_content_detail_card_item.html' with title=item.title description=item.description cta_href=item.cta_url cta_label=item.cta_label icon_name="bullseye-pixel" icon_size=16 only %}
3131
</li>
3232
{% endfor %}
3333
</ul>

templates/v3/includes/_content_detail_card_item.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
description (required) — card body text
66
icon_name (optional) — icon name for includes/icon.html (e.g. "bullseye-arrow").
77
If omitted (and badge_count not set), card is rendered without icon and modifier --has-icon is not applied.
8+
icon_size (optional) - Size in pixels of icon, defaults to 24
89
badge_count (optional) — when set (e.g. in carousel), shows a non-clickable count badge instead of icon.
910
title_url (optional) — if set, title is wrapped in a link
1011
cta_label (optional) — if set with cta_href, renders a CTA link below description (or span if cta_as_span)
@@ -21,7 +22,7 @@
2122
</div>
2223
{% elif icon_name %}
2324
<div class="content-detail-icon__icon" aria-hidden="true">
24-
{% include "includes/icon.html" with icon_name=icon_name icon_class="content-detail-icon__icon-svg" icon_size=24 %}
25+
{% include "includes/icon.html" with icon_name=icon_name icon_class="content-detail-icon__icon-svg" icon_size=icon_size|default:24 %}
2526
</div>
2627
{% endif %}
2728
<h3 class="content-detail-icon__title">

0 commit comments

Comments
 (0)