test: move V3 canaries to test_v3_urls.py

Replace the 200-when-v3-flag-on assertions with 404-when-off
assertions that actually exercise the waffle gate in
V3AuthContextMixin.dispatch. Living in their own file also
makes these easy to delete once V3 ships and the flag is
retired.

Author: julioest

users/tests/test_urls.py

@@ -1,4 +1,3 @@
-import waffle.testutils
 from django.contrib.auth import get_user_model
 
 
@@ -45,50 +44,6 @@ def test_password_reset_url(tp, db):
     tp.response_200(res)
 
 
-@waffle.testutils.override_flag("v3", active=True)
-def test_v3_password_reset_url(tp, db):
-    """
-    GET /v3/accounts/password/reset/
-
-    Canary test that the V3 password reset entry page renders.
-    """
-    res = tp.get("v3-password-reset")
-    tp.response_200(res)
-
-
-@waffle.testutils.override_flag("v3", active=True)
-def test_v3_password_reset_done_url(tp, db):
-    """
-    GET /v3/accounts/password/reset/done/
-
-    Canary test that the V3 password reset confirmation page renders.
-    """
-    res = tp.get("v3-password-reset-done")
-    tp.response_200(res)
-
-
-@waffle.testutils.override_flag("v3", active=True)
-def test_v3_password_reset_from_key_url(tp, db):
-    """
-    GET /v3/accounts/password/reset/key/
-
-    Canary test that the V3 change password page renders.
-    """
-    res = tp.get("v3-password-reset-from-key")
-    tp.response_200(res)
-
-
-@waffle.testutils.override_flag("v3", active=True)
-def test_v3_password_reset_from_key_done_url(tp, db):
-    """
-    GET /v3/accounts/password/reset/key/done/
-
-    Canary test that the V3 password changed confirmation page renders.
-    """
-    res = tp.get("v3-password-reset-from-key-done")
-    tp.response_200(res)
-
-
 def test_signup_200(tp, db):
     """
     GET /accounts/signup/

users/tests/test_v3_urls.py

@@ -0,0 +1,39 @@
+import waffle.testutils
+
+
+@waffle.testutils.override_flag("v3", active=False)
+def test_v3_password_reset_url_404_when_flag_off(tp, db):
+    """
+    GET /v3/accounts/password/reset/ with the v3 flag off returns 404.
+
+    Verifies V3AuthContextMixin.dispatch gates the page behind the flag.
+    """
+    res = tp.get("v3-password-reset")
+    tp.response_404(res)
+
+
+@waffle.testutils.override_flag("v3", active=False)
+def test_v3_password_reset_done_url_404_when_flag_off(tp, db):
+    """
+    GET /v3/accounts/password/reset/done/ with the v3 flag off returns 404.
+    """
+    res = tp.get("v3-password-reset-done")
+    tp.response_404(res)
+
+
+@waffle.testutils.override_flag("v3", active=False)
+def test_v3_password_reset_from_key_url_404_when_flag_off(tp, db):
+    """
+    GET /v3/accounts/password/reset/key/ with the v3 flag off returns 404.
+    """
+    res = tp.get("v3-password-reset-from-key")
+    tp.response_404(res)
+
+
+@waffle.testutils.override_flag("v3", active=False)
+def test_v3_password_reset_from_key_done_url_404_when_flag_off(tp, db):
+    """
+    GET /v3/accounts/password/reset/key/done/ with the v3 flag off returns 404.
+    """
+    res = tp.get("v3-password-reset-from-key-done")
+    tp.response_404(res)