PR feedback: Update exception catching, make tags multi select

Author: jlchilders11

news/tasks.py

@@ -325,6 +325,9 @@ def set_summary_for_link_page(pk: int):
         logger.debug(f"Fetched {len(markup)=} for entry.{pk=}...")
         _title, content = extract_article(markup)
         logger.info(f"extracted content from {external_url=}, {markup[:100]=}")
+    except UnsafeURLError:
+        logger.warning(f"Refusing to fetch unsafe {external_url=} for {pk=}")
+        return
     except requests.RequestException as e:
         logger.error(f"Error fetching content from {external_url=}: {e=}")
         return

news/views.py

@@ -588,7 +588,7 @@ def post(self, request, *args, **kwargs):
                         "An internal database error has occurred. Please contact an admin."
                     ),
                 )
-                context = self.get_context_data()
+                context = self.get_context_data(form=form, post_type_selected=post_type)
                 return self.render_to_response(context)
 
             try:
@@ -613,26 +613,29 @@ def post(self, request, *args, **kwargs):
                     )
                     page.image = wagtail_image
                 tags = []
-                if related_library := post_data.get("related_libraries"):
-                    try:
-                        lib = Library.objects.get(slug=related_library)
-                    except Library.DoesNotExist:
-                        messages.error(
-                            request,
-                            _(
-                                "That related library does not exist, please select another."
-                            ),
+                if related_libraries := post_data.getlist("related_libraries"):
+                    for library in related_libraries:
+                        try:
+                            lib = Library.objects.get(slug=library)
+                        except Library.DoesNotExist:
+                            messages.error(
+                                request,
+                                _(
+                                    "That related library does not exist, please select another."
+                                ),
+                            )
+                            context = self.get_context_data(
+                                form=form, post_type_selected=post_type
+                            )
+                            return self.render_to_response(context)
+
+                        tag, created = ContentTag.objects.get_or_create(
+                            slug=lib.slug,
+                            defaults={
+                                "name": lib.name,
+                            },
                         )
-                        context = self.get_context_data()
-                        return self.render_to_response(context)
-
-                    tag, created = ContentTag.objects.get_or_create(
-                        slug=lib.slug,
-                        defaults={
-                            "name": lib.name,
-                        },
-                    )
-                    tags.append(tag)
+                        tags.append(tag)
                 index_page.add_child(instance=page)
                 if tags:
                     page.tags.add(*tags)

templates/news/v3/create.html

@@ -184,7 +184,7 @@ <h1 class="create-post-page__title">Create Post</h1>
 
           {% include "v3/includes/_field_file.html" with name="image" label="Image" accept="image/png,image/jpeg" preview=True alpine_error="errors.image" error=form.errors.image.0 help_text="This should be a PNG or JPEG format and no larger than 5MB" extra_class="field--file-narrow create-post-page__field-image" %}
 
-          {% include "v3/includes/_field_dropdown.html" with name="related_libraries" label="Related Libraries" options=related_libraries_options placeholder="Select" selected=form.data.related_libraries %}
+          {% include "v3/includes/_field_multiselect.html" with name="related_libraries" label="Related Libraries" options=related_libraries_options placeholder="Select" selected=form.data.related_libraries %}
 
           {% include "v3/includes/_field_datetime.html" with name="publish_at" label="Publish Date *" value=form.publish_at.value|default:publish_at_initial %}