Skip to content

Commit d26d5c7

Browse files
committed
QA feedback only allow image deletion if permission is set
1 parent 8458c08 commit d26d5c7

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

users/views.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,12 @@ class CurrentUserAPIView(generics.RetrieveUpdateAPIView):
8080
permission_classes = [IsAuthenticated]
8181

8282
def perform_update(self, serializer: CurrentUserSerializer):
83-
instance = serializer.save()
84-
if self.request.POST.get("delete_profile_image", "").lower() == "true":
83+
instance: User = serializer.save()
84+
# Only allow for image deletion if the user is allowed to update their image.
85+
if (
86+
self.request.POST.get("delete_profile_image", "").lower() == "true"
87+
and instance.can_update_image
88+
):
8589
instance.profile_image.delete()
8690

8791
def get_object(self):

0 commit comments

Comments
 (0)