Tidy up pdf reader and render tab in paperworks

Author: vinniefalco

paperworks/lib/pdf_reader.py

@@ -35,14 +35,16 @@
 
 
 def _extract_doc_number(text):
-    """Find the document number, preferring the 'Document Number:' field."""
+    """Find the document number from the 'Document Number:' structured field.
+
+    Only the structured header is trusted. Free-text scanning is intentionally
+    absent: paper titles that mention other paper numbers (e.g. "Coroutine
+    Executors and P2464R0") would otherwise be misidentified.
+    """
     m = _DOC_FIELD_RE.search(text)
     if m:
         return m.group(1).upper()
-    m = _DOC_NUM_RE.search(text)
-    if not m:
-        return None
-    return (m.group(1) or m.group(2) or m.group(3)).upper()
+    return None
 
 
 def _doc_number_from_filename(path):

paperworks/lib/templates/index.html

@@ -131,7 +131,8 @@
     .render-card.empty { cursor: pointer; color: var(--text-muted); font-size: 12px; }
     .render-card.empty:hover { border-color: var(--blue); background: rgba(88,166,255,0.05); }
     .render-card.drop-over { border-color: var(--blue); background: rgba(88,166,255,0.12); }
-    .render-card.filled { border-style: solid; border-color: var(--border); }
+    .render-card.filled { border-style: solid; border-color: var(--border); cursor: pointer; }
+    .render-card.filled:hover { border-color: rgba(88,166,255,0.4); background: rgba(88,166,255,0.04); }
     .render-card.filled.rendering { border-color: rgba(88,166,255,0.4); animation: bpulse 1.2s ease-in-out infinite; }
     .render-card .card-name { font-family: var(--mono); font-size: 11px; color: var(--text); padding: 0 12px; width: 100%; overflow: hidden; text-overflow: ellipsis; white-space: nowrap; direction: rtl; text-align: center; }
     .render-card .card-x { position: absolute; top: 4px; right: 8px; background: none; border: none; color: var(--text-muted); cursor: pointer; font-size: 14px; padding: 0 3px; line-height: 1; }
@@ -689,11 +690,13 @@ <h2>Activity Log</h2>
   card.addEventListener('dragover',e=>{e.preventDefault();card.classList.add('drop-over');});
   card.addEventListener('dragleave',()=>card.classList.remove('drop-over'));
   card.addEventListener('drop',e=>{e.preventDefault();card.classList.remove('drop-over');handleCardDrop(card,e.dataTransfer.files);});
-  card.addEventListener('click',()=>{
+  const emptyClick=()=>{
     const inp=document.createElement('input');inp.type='file';inp.multiple=true;inp.accept='.md';
     inp.addEventListener('change',()=>{if(inp.files.length)handleCardDrop(card,inp.files);});
     inp.click();
-  });
+  };
+  card._emptyClick=emptyClick;
+  card.addEventListener('click',emptyClick);
   grid.appendChild(card);
 }
 function handleCardDrop(card,fileList){
@@ -712,6 +715,7 @@ <h2>Activity Log</h2>
   ensureEmptyCard();
 }
 function fillCard(card,file,previewTab){
+  if(card._emptyClick){card.removeEventListener('click',card._emptyClick);card._emptyClick=null;}
   card.className='render-card filled';
   card.textContent='';
   card._file=file;
@@ -734,6 +738,14 @@ <h2>Activity Log</h2>
   };
   card.appendChild(btn);
   card._actionBtn=btn;
+  card.addEventListener('click',e=>{
+    if(e.target===x||x.contains(e.target)) return;
+    if(e.target===btn||btn.contains(e.target)) return;
+    card._pdfPath=null;
+    if(btn){btn.textContent='RENDER';btn.className='btn btn-blue';btn.style.cssText='font-size:10px;padding:2px 8px;margin-top:6px';}
+    if(_previewOn) card._previewTab=window.open('about:blank','_blank');
+    renderCard(card);
+  });
   renderCard(card);
 }
 async function renderCard(card){

paperworks/tests/test_pdf_reader.py

@@ -0,0 +1,27 @@
+"""Tests for pdf_reader._extract_doc_number."""
+import unittest
+
+from lib.pdf_reader import _extract_doc_number
+
+
+class TestExtractDocNumber(unittest.TestCase):
+    def test_structured_field_wins(self):
+        text = "Document Number: P4096R0\nCoroutine Executors and P2464R0"
+        assert _extract_doc_number(text) == "P4096R0"
+
+    def test_title_paper_number_ignored(self):
+        """A paper number in the title must not be returned."""
+        text = "Coroutine Executors and P2464R0\nSome other content"
+        assert _extract_doc_number(text) is None
+
+    def test_no_field_returns_none(self):
+        text = "Just some text with no document number field."
+        assert _extract_doc_number(text) is None
+
+    def test_case_insensitive_field(self):
+        text = "document number: d4007r0\nSome title"
+        assert _extract_doc_number(text) == "D4007R0"
+
+    def test_n_paper_structured(self):
+        text = "Document Number: N4950\nWorking Draft"
+        assert _extract_doc_number(text) == "N4950"