Implement review suggestions

Author: cgobat

CHANGES.rst

@@ -37,7 +37,7 @@ Service fixes and enhancements
 svo_fps
 ^^^^^^^
 
-- Add ``get_filter_params`` to allow retrieval of filter metadata. [#3528]
+- Add ``get_filter_metadata`` to allow retrieval of filter metadata. [#3528]
 
 heasarc
 ^^^^^^^

astroquery/svo_fps/core.py

@@ -108,8 +108,8 @@ def get_filter_index(self, wavelength_eff_min, wavelength_eff_max, **kwargs):
                 "succeed. Try increasing the timeout limit if a large range is needed."
             )
 
-    def get_filter_params(self, filter_id, cache=True, timeout=None):
-        f"""Get metadata/parameters for the requested Filter ID from SVO
+    def get_filter_metadata(self, filter_id, *, cache=True, timeout=None):
+        """Get metadata/parameters for the requested Filter ID from SVO
 
         Parameters
         ----------
@@ -121,7 +121,7 @@ def get_filter_params(self, filter_id, cache=True, timeout=None):
             Defaults to True. If set overrides global caching behavior.
             See :ref:`caching documentation <astroquery_cache>`.
         timeout : int
-            Timeout in seconds. If not specified, defaults to {conf.timeout}.
+            Timeout in seconds. If not specified, defaults to ``conf.timeout``.
 
         Returns
         -------

astroquery/svo_fps/tests/test_svo_fps_remote.py

@@ -25,8 +25,8 @@ def test_get_transmission_data(self, test_filter_id):
 
     @pytest.mark.parametrize('test_filter_id',
                              ['NewHorizons/MVIC.Blue', 'Palomar/ZTF.r'])
-    def test_get_filter_params(self, test_filter_id):
-        params = SvoFps.get_filter_params(test_filter_id)
+    def test_get_filter_metadata(self, test_filter_id):
+        params = SvoFps.get_filter_metadata(test_filter_id)
         # Check if expected keys are present
         assert "WavelengthEff" in params
         assert "ZeroPoint" in params