updating to js-based implementation

Author: cpparts

js/models/message_handler.js

@@ -28,6 +28,7 @@ export default class MessageHandler {
       );
     }
     catalog.addSources(markers);
+    this.messageHandler.handleGetOverlays();
   }
 
   handleChangeFoV(msg) {
@@ -75,6 +76,7 @@ export default class MessageHandler {
   handleAddCatalogFromURL(msg) {
     const options = convertOptionNamesToCamelCase(msg["options"] || {});
     this.aladin.addCatalog(A.catalogFromURL(msg["votable_URL"], options));
+    this.messageHandler.handleGetOverlays();
   }
 
   handleAddMOCFromURL(msg) {
@@ -138,6 +140,7 @@ export default class MessageHandler {
           break;
       }
     }
+    this.messageHandler.handleGetOverlays();
   }
 
   handleRemoveOverlay = (msg) => {
@@ -232,6 +235,7 @@ export default class MessageHandler {
       options,
       (catalog) => {
         this.aladin.addCatalog(catalog);
+        this.messageHandler.handleGetOverlays();
       },
       false,
     );

src/ipyaladin/widget.py

@@ -550,7 +550,6 @@ def add_markers(
                 "options": catalog_options,
             }
         )
-        self.get_overlays()
 
     def _save_file(self, path: str, buffer: bytes) -> None:
         """Save a file from a buffer.
@@ -674,7 +673,6 @@ def add_catalog_from_URL(
                 "options": votable_options,
             }
         )
-        self.get_overlays()
 
     @widget_should_be_loaded
     def add_fits(self, fits: Union[str, Path, HDUList], **image_options: any) -> None:
@@ -880,16 +878,6 @@ def add_table(
             {"event_name": "add_table", "options": table_options},
             buffers=[table_bytes.getvalue()],
         )
-        if not self._ready:
-            warnings.warn(
-                "The table has not yet finished loading into the widget, so the "
-                "overlays list has not been updated. Please call `get_overlays()` "
-                "to update the list.",
-                UserWarning,
-                stacklevel=2,
-            )
-        else:
-            self.get_overlays()
 
     @widget_should_be_loaded
     def add_graphic_overlay_from_region(
@@ -970,7 +958,6 @@ def add_graphic_overlay_from_region(
                 "graphic_options": graphic_options,
             }
         )
-        self.get_overlays()
 
     @widget_should_be_loaded
     def add_overlay_from_stcs(
@@ -1036,7 +1023,6 @@ def add_graphic_overlay_from_stcs(
                 "graphic_options": overlay_options,
             }
         )
-        self.get_overlays()
 
     @widget_should_be_loaded
     def remove_overlay(self, overlay_name: Union[Iterable[str], str]) -> None:

src/tests/test_aladin.py

@@ -255,7 +255,7 @@ def test_add_graphic_overlay_from_stcs_iterables(
     mock_send = Mock()
     monkeypatch.setattr(Aladin, "send", mock_send)
     aladin.add_graphic_overlay_from_stcs(stcs_strings)
-    regions_info = mock_send.call_args_list[0].args[0]["regions_infos"]
+    regions_info = mock_send.call_args[0][0]["regions_infos"]
     assert isinstance(regions_info, list)
     assert regions_info[0]["infos"]["stcs"] in stcs_strings