Skip to content

Commit 09ada67

Browse files
committed
test/cfg/runtests.sh: extracted cppcheck invocation into function
1 parent 2e238e6 commit 09ada67

1 file changed

Lines changed: 31 additions & 27 deletions

File tree

test/cfg/runtests.sh

Lines changed: 31 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,10 @@ function cxx_syntax {
7171
${CXX} "${CXX_OPT[@]}" "$@"
7272
}
7373

74+
function cppcheck_run {
75+
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" "$@"
76+
}
77+
7478
# posix.c
7579
function posix_fn {
7680
echo "POSIX assumed to be present, checking syntax with ${CC} now."
@@ -480,109 +484,109 @@ function check_file {
480484
case $f in
481485
boost.cpp)
482486
boost_fn
483-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --library="$lib" "${DIR}""$f"
487+
cppcheck_run --library="$lib" "${DIR}""$f"
484488
;;
485489
bsd.c)
486490
bsd_fn
487-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --library="$lib" "${DIR}""$f"
491+
cppcheck_run --library="$lib" "${DIR}""$f"
488492
;;
489493
cairo.c)
490494
cairo_fn
491-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --library="$lib" "${DIR}""$f"
495+
cppcheck_run --library="$lib" "${DIR}""$f"
492496
;;
493497
cppunit.cpp)
494498
cppunit_fn
495-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --library="$lib" "${DIR}""$f"
499+
cppcheck_run --library="$lib" "${DIR}""$f"
496500
;;
497501
emscripten.cpp)
498502
emscripten_fn
499-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --library="$lib" "${DIR}""$f"
503+
cppcheck_run --library="$lib" "${DIR}""$f"
500504
;;
501505
gnu.c)
502506
gnu_fn
503507
# TODO: posix needs to specified first or it has a different mmap() config
504508
# TODO: get rid of posix dependency
505-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --library=posix,"$lib" "${DIR}"gnu.c
509+
cppcheck_run --library=posix,"$lib" "${DIR}"gnu.c
506510
;;
507511
googletest.cpp)
508512
googletest_fn
509-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --library="$lib" "${DIR}""$f"
513+
cppcheck_run --library="$lib" "${DIR}""$f"
510514
;;
511515
gtk.c)
512516
gtk_fn
513-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --library="$lib" "${DIR}""$f"
517+
cppcheck_run --library="$lib" "${DIR}""$f"
514518
;;
515519
kde.cpp)
516520
# TODO: "kde-4config" is no longer commonly available in recent distros
517521
#kde_fn
518-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --library="$lib" --library=qt "${DIR}""$f"
522+
cppcheck_run --library="$lib" --library=qt "${DIR}""$f"
519523
;;
520524
libcurl.c)
521525
libcurl_fn
522-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --library="$lib" "${DIR}""$f"
526+
cppcheck_run --library="$lib" "${DIR}""$f"
523527
;;
524528
libsigc++.cpp)
525529
libsigcpp_fn
526-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --library="$lib" "${DIR}""$f"
530+
cppcheck_run --library="$lib" "${DIR}""$f"
527531
;;
528532
lua.c)
529533
lua_fn
530-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --library="$lib" "${DIR}""$f"
534+
cppcheck_run --library="$lib" "${DIR}""$f"
531535
;;
532536
mfc.cpp)
533537
mfc_fn
534-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --platform=win64 --library="$lib" "${DIR}""$f"
538+
cppcheck_run --platform=win64 --library="$lib" "${DIR}""$f"
535539
;;
536540
opencv2.cpp)
537541
# TODO: "opencv.pc" is not commonly available in distros
538542
#opencv2_fn
539-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --library="$lib" "${DIR}""$f"
543+
cppcheck_run --library="$lib" "${DIR}""$f"
540544
;;
541545
openmp.c)
542546
openmp_fn
543-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --library="$lib" "${DIR}""$f"
547+
cppcheck_run --library="$lib" "${DIR}""$f"
544548
;;
545549
openssl.c)
546550
openssl_fn
547-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --library="$lib" "${DIR}""$f"
551+
cppcheck_run --library="$lib" "${DIR}""$f"
548552
;;
549553
posix.c)
550554
posix_fn
551-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --library="$lib" "${DIR}""$f"
555+
cppcheck_run --library="$lib" "${DIR}""$f"
552556
;;
553557
python.c)
554558
python_fn
555-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --library="$lib" "${DIR}""$f"
559+
cppcheck_run --library="$lib" "${DIR}""$f"
556560
;;
557561
qt.cpp)
558562
qt_fn
559-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --library="$lib" "${DIR}""$f"
563+
cppcheck_run --library="$lib" "${DIR}""$f"
560564
;;
561565
selinux.c)
562566
selinux_fn
563-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --library="$lib" "${DIR}""$f"
567+
cppcheck_run --library="$lib" "${DIR}""$f"
564568
;;
565569
sqlite3.c)
566570
sqlite3_fn
567-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --library="$lib" "${DIR}""$f"
571+
cppcheck_run --library="$lib" "${DIR}""$f"
568572
;;
569573
std.c)
570574
std_c_fn
571-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" "${DIR}""$f"
575+
cppcheck_run "${DIR}""$f"
572576
;;
573577
std.cpp)
574578
std_cpp_fn
575-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" "${DIR}""$f"
579+
cppcheck_run "${DIR}""$f"
576580
;;
577581
windows.cpp)
578582
windows_fn
579-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --platform=win32A --library="$lib" "${DIR}""$f"
580-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --platform=win32W --library="$lib" "${DIR}""$f"
581-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --platform=win64 --library="$lib" "${DIR}""$f"
583+
cppcheck_run --platform=win32A --library="$lib" "${DIR}""$f"
584+
cppcheck_run --platform=win32W --library="$lib" "${DIR}""$f"
585+
cppcheck_run --platform=win64 --library="$lib" "${DIR}""$f"
582586
;;
583587
wxwidgets.cpp)
584588
wxwidgets_fn
585-
"${CPPCHECK}" "${CPPCHECK_OPT[@]}" --library="$lib" "${DIR}""$f"
589+
cppcheck_run --library="$lib" "${DIR}""$f"
586590
;;
587591
*)
588592
echo "Unhandled file $f"

0 commit comments

Comments
 (0)