Update checkclass.cpp

chrchr-github · web-flow · commit 185c0c148828 · 2026-02-23T10:09:34.000+01:00
diff --git a/lib/checkclass.cpp b/lib/checkclass.cpp
@@ -2545,8 +2545,10 @@ bool CheckClass::checkConstFunc(const Scope *scope, const Function *func, Member
                     }
                 }
             } else if (lhs->str() == ":" && lhs->astParent() && lhs->astParent()->str() == "(") { // range-based for-loop (C++11)
-                // TODO: We could additionally check what is done with the elements to avoid false negatives. Here we just rely on "const" keyword being used.
-                if (lhs->astParent()->strAt(1) != "const")
+                const Variable* loopVar = lhs->astOperand1()->variable();
+                if (!loopVar || !loopVar->valueType())
+                    return false;
+                if (!loopVar->valueType()->isConst(loopVar->valueType()->pointer))
                     return false;
             } else {
                 if (lhs->isAssignmentOp()) {

Original file line number	Diff line number	Diff line change
`@@ -2545,8 +2545,10 @@ bool CheckClass::checkConstFunc(const Scope scope, const Function func, Member`
`2545`	`2545`	`}`
`2546`	`2546`	`}`
`2547`	`2547`	`} else if (lhs->str() == ":" && lhs->astParent() && lhs->astParent()->str() == "(") { // range-based for-loop (C++11)`
`2548`		`- // TODO: We could additionally check what is done with the elements to avoid false negatives. Here we just rely on "const" keyword being used.`
`2549`		`- if (lhs->astParent()->strAt(1) != "const")`
	`2548`	`+ const Variable* loopVar = lhs->astOperand1()->variable();`
	`2549`	`+ if (!loopVar \|\| !loopVar->valueType())`
	`2550`	`+ return false;`
	`2551`	`+ if (!loopVar->valueType()->isConst(loopVar->valueType()->pointer))`
`2550`	`2552`	`return false;`
`2551`	`2553`	`} else {`
`2552`	`2554`	`if (lhs->isAssignmentOp()) {`