Skip to content

Commit 1907ed7

Browse files
author
Felix Faber
committed
Restoring TODO and fixing whitespace
1 parent c115c52 commit 1907ed7

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

lib/importproject.cpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ bool ImportProject::importSln(std::istream &istr, const std::string &path, const
451451
std::vector<SharedItemsProject> sharedItemsProjects{};
452452
while (std::getline(istr,line)) {
453453
if (!startsWith(line,"Project("))
454-
continue;
454+
continue;
455455
const std::string::size_type pos = line.find(".vcxproj");
456456
if (pos == std::string::npos)
457457
continue;
@@ -774,7 +774,9 @@ bool ImportProject::importVcxproj(const std::string &filename, std::map<std::str
774774
}
775775
}
776776
}
777-
}
777+
}
778+
// # TODO: support signedness of char via /J (and potential XML option for it)?
779+
// we can only set it globally but in this context it needs to be treated per file
778780

779781
// Include shared items project files
780782
std::vector<std::string> sharedItemsIncludePaths{};
@@ -807,7 +809,7 @@ bool ImportProject::importVcxproj(const std::string &filename, std::map<std::str
807809
FileSettings fs;
808810
fs.filename = cfilename;
809811
fs.cfg = p.name;
810-
// TODO: detect actual MSC version
812+
// TODO: detect actual MSC version
811813
fs.msc = true;
812814
fs.useMfc = useOfMfc;
813815
fs.defines = "_WIN32=1";

0 commit comments

Comments
 (0)