Fix clang-tidy issues

Author: glankk

lib/cppcheck.cpp

@@ -1038,7 +1038,7 @@ unsigned int CppCheck::checkInternal(const FileWithDetails& file, const std::str
         // Get directives
         std::list<Directive> directives;
         Preprocessor::createDirectives(tokens1, directives);
-        preprocessor.simplifyPragmaAsm(tokens1);
+        Preprocessor::simplifyPragmaAsm(tokens1);
 
         // This needs to be a linked list to allow new configurations to be discovered
         // and added while iterating and checking existing configurations
@@ -1051,7 +1051,7 @@ unsigned int CppCheck::checkInternal(const FileWithDetails& file, const std::str
             preprocessor.inlineSuppressions(data.tokens, mSuppressions.nomsg);
             Preprocessor::removeComments(data.tokens);
             Preprocessor::createDirectives(data.tokens, directives);
-            preprocessor.simplifyPragmaAsm(data.tokens);
+            Preprocessor::simplifyPragmaAsm(data.tokens);
             // Discover new configurations from included file
             if ((mSettings.checkAllConfigurations && mSettings.userDefines.empty()) || mSettings.force)
                 preprocessor.getConfigs(data.filename, data.tokens, configDefines, configurations);

lib/preprocessor.cpp

@@ -971,11 +971,6 @@ std::size_t Preprocessor::calculateHash(const simplecpp::TokenList &tokens1, con
 }
 
 void Preprocessor::simplifyPragmaAsm(simplecpp::TokenList &tokenList)
-{
-    Preprocessor::simplifyPragmaAsmPrivate(tokenList);
-}
-
-void Preprocessor::simplifyPragmaAsmPrivate(simplecpp::TokenList &tokenList)
 {
     // assembler code..
     for (simplecpp::Token *tok = tokenList.front(); tok; tok = tok->next) {

lib/preprocessor.h

@@ -159,8 +159,6 @@ class CPPCHECKLIB WARN_UNUSED Preprocessor {
 
     void reportOutput(const simplecpp::OutputList &outputList, bool showerror);
 
-    static void simplifyPragmaAsmPrivate(simplecpp::TokenList &tokenList);
-
     /**
      * Include file types.
      */

test/testpreprocessor.cpp

@@ -123,7 +123,7 @@ class TestPreprocessor : public TestFixture {
         if (inlineSuppression)
             preprocessor.inlineSuppressions(tokens, *inlineSuppression);
         Preprocessor::removeComments(tokens);
-        preprocessor.simplifyPragmaAsm(tokens);
+        Preprocessor::simplifyPragmaAsm(tokens);
 
         preprocessor.reportOutput(outputList, true);