clang-tidy

danmar · danmar · commit 365c47dd4ff7 · 2025-05-21T21:14:42.000+02:00
diff --git a/lib/checkother.cpp b/lib/checkother.cpp
@@ -438,7 +438,8 @@ void CheckOther::warningDangerousTypeCast()
 
 void CheckOther::dangerousTypeCastError(const Token *tok, bool isPtr)
 {
-    const std::string type = isPtr ? "pointer" : "reference";
+    //const std::string type = isPtr ? "pointer" : "reference";
+    (void)isPtr;
     reportError(tok, Severity::warning, "dangerousTypeCast",
                 "Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast",
                 CWE398, Certainty::normal);

Original file line number	Diff line number	Diff line change
`@@ -438,7 +438,8 @@ void CheckOther::warningDangerousTypeCast()`
`438`	`438`
`439`	`439`	`void CheckOther::dangerousTypeCastError(const Token *tok, bool isPtr)`
`440`	`440`	`{`
`441`		`- const std::string type = isPtr ? "pointer" : "reference";`
	`441`	`+ //const std::string type = isPtr ? "pointer" : "reference";`
	`442`	`+ (void)isPtr;`
`442`	`443`	`reportError(tok, Severity::warning, "dangerousTypeCast",`
`443`	`444`	`"Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast",`
`444`	`445`	`CWE398, Certainty::normal);`