test

Author: firewave

cli/stacktrace.cpp

@@ -36,7 +36,6 @@ void print_stacktrace(FILE* output, int start_idx, bool demangling, int maxdepth
     static constexpr auto ADDRESSDISPLAYLENGTH = (sizeof(long) == 8) ? 12 : 8;
 
     void *callstackArray[32]= {nullptr}; // the less resources the better...
-    fputs("backtrace\n", output);
     const int currentdepth = backtrace(callstackArray, static_cast<int>(getArrayLength(callstackArray)));
     if (currentdepth == 0) {
         fputs("Callstack could not be obtained (backtrace)\n", output);
@@ -45,17 +44,13 @@ void print_stacktrace(FILE* output, int start_idx, bool demangling, int maxdepth
     if (currentdepth == getArrayLength(callstackArray)) {
         fputs("Callstack might be truncated\n", output);
     }
-    fprintf(output, "currentdepth %d\n", currentdepth);
     // set offset to 1 to omit the printing function itself
     int offset=start_idx+1; // some entries on top are within our own exception handling code or libc
-    fprintf(output, "offset %d\n", offset);
     if (maxdepth<0)
         maxdepth=currentdepth-offset;
     else
         maxdepth = std::min(maxdepth, currentdepth);
-    fprintf(output, "maxdepth %d\n", maxdepth);
 
-    fputs("backtrace_symbols\n", output);
     char **symbolStringList = backtrace_symbols(callstackArray, currentdepth);
     if (!symbolStringList) {
         fputs("Callstack could not be obtained (backtrace_symbols)\n", output);
@@ -66,22 +61,19 @@ void print_stacktrace(FILE* output, int start_idx, bool demangling, int maxdepth
     bool own_code = false;
     char demangle_buffer[2048]= {0};
     for (int i = offset; i < maxdepth; ++i) {
-        fprintf(output, "offset %d\n", offset);
         const char * const symbolString = symbolStringList[i];
-        fprintf(output, "symbolString %p\n", (void*)symbolString);
         fprintf(output, "%s\n", symbolString);
+        continue;
         // skip all leading libc symbols so the first symbol is our code
         if (omit_above_own && !own_code) {
             if (strstr(symbolString, "/libc.so.6") != nullptr)
                 continue;
             own_code = true;
             offset = i; // make sure the numbering is continuous if we omit frames
         }
-        fprintf(output, "offset %d\n", offset);
         const char * realnameString = nullptr;
         if (demangling) {
-            const char * const firstBracketName = strchr(symbolString, '(');
-            fprintf(output, "firstBracketName %p\n", (void*)firstBracketName);
+            const char * const firstBracketName = strchr(symbolString, '('); // TODO: check
             const char * const plus = strchr(firstBracketName, '+');
             if (plus && (plus>(firstBracketName+1))) {
                 char input_buffer[1024]= {0};
@@ -97,13 +89,13 @@ void print_stacktrace(FILE* output, int start_idx, bool demangling, int maxdepth
         fprintf(output, "#%-2d 0x",
                 ordinal);
 
-        const char * const firstBracketAddress  = strchr(symbolString, '[');
+        const char * const firstBracketAddress = strchr(symbolString, '[');// TODO: check
         fprintf(output, "firstBracketAddress %p\n", (void*)firstBracketAddress);
-        const char * const secondBracketAddress = strchr(firstBracketAddress, ']');
+        const char * const secondBracketAddress = strchr(firstBracketAddress, ']'); // TODO: check
         fprintf(output, "secondBracketAddress %p\n", (void*)secondBracketAddress);
         const int padLen = [&]() {
             // TODO: handle firstBracketAddress being NULL
-            const char * const beginAddress         = firstBracketAddress+3;
+            const char * const beginAddress = firstBracketAddress+3;
             fprintf(output, "beginAddress %p\n", (void*)beginAddress);
             const int addressLen = int(secondBracketAddress-beginAddress);
             fprintf(output, "addressLen %d\n", addressLen);