Fix #13944: FN constParameterPointer in method in derived class

Add inconclusive and default=false (instead of true) in checkConstPointer.

Author: ceJce

lib/checkother.cpp

@@ -2008,8 +2008,9 @@ void CheckOther::checkConstPointer()
             nonConstPointers.emplace(var);
     }
     for (const Variable *p: pointers) {
+        bool inconclusive = false;
         if (p->isArgument()) {
-            if (!p->scope() || !p->scope()->function || p->scope()->function->isImplicitlyVirtual(true) || p->scope()->function->hasVirtualSpecifier())
+            if (!p->scope() || !p->scope()->function || p->scope()->function->isImplicitlyVirtual(false, (bool*)nullptr, &inconclusive) || p->scope()->function->hasVirtualSpecifier())
                 continue;
             if (p->isMaybeUnused())
                 continue;
@@ -2026,12 +2027,12 @@ void CheckOther::checkConstPointer()
                 continue;
             if (p->typeStartToken() && p->typeStartToken()->isSimplifiedTypedef() && !(Token::simpleMatch(p->typeEndToken(), "*") && !p->typeEndToken()->isSimplifiedTypedef()))
                 continue;
-            constVariableError(p, p->isArgument() ? p->scope()->function : nullptr);
+            constVariableError(p, p->isArgument() ? p->scope()->function : nullptr, &inconclusive);
         }
     }
 }
 
-void CheckOther::constVariableError(const Variable *var, const Function *function)
+void CheckOther::constVariableError(const Variable *var, const Function *function, bool* inconclusive)
 {
     if (!var) {
         reportError(nullptr, Severity::style, "constParameter", "Parameter 'x' can be declared with const");
@@ -2062,7 +2063,7 @@ void CheckOther::constVariableError(const Variable *var, const Function *functio
         id += "Pointer";
     }
 
-    reportError(std::move(errorPath), Severity::style, id.c_str(), message, CWE398, Certainty::normal);
+    reportError(std::move(errorPath), Severity::style, id.c_str(), message, CWE398, (inconclusive && *inconclusive) ? Certainty::inconclusive : Certainty::normal);
 }
 
 //---------------------------------------------------------------------------

lib/checkother.h

@@ -215,7 +215,7 @@ class CPPCHECKLIB CheckOther : public Check {
     void suspiciousFloatingPointCastError(const Token *tok);
     void invalidPointerCastError(const Token* tok, const std::string& from, const std::string& to, bool inconclusive, bool toIsInt);
     void passedByValueError(const Variable* var, bool inconclusive, bool isRangeBasedFor = false);
-    void constVariableError(const Variable *var, const Function *function);
+    void constVariableError(const Variable *var, const Function *function, bool * inconclusive = nullptr);
     void constStatementError(const Token *tok, const std::string &type, bool inconclusive);
     void signedCharArrayIndexError(const Token *tok);
     void unknownSignCharArrayIndexError(const Token *tok);

lib/symboldatabase.cpp

@@ -4813,8 +4813,10 @@ void Function::addArguments(const Scope *scope)
     }
 }
 
-bool Function::isImplicitlyVirtual(bool defaultVal, bool* pFoundAllBaseClasses) const
+bool Function::isImplicitlyVirtual(bool defaultVal, bool* pFoundAllBaseClasses, bool* inconclusive) const
 {
+    if (inconclusive)
+        *inconclusive = false; // assume not inconclusive.
     if (hasVirtualSpecifier() || hasOverrideSpecifier() || hasFinalSpecifier())
         return true;
     bool foundAllBaseClasses = true;
@@ -4824,7 +4826,10 @@ bool Function::isImplicitlyVirtual(bool defaultVal, bool* pFoundAllBaseClasses)
         *pFoundAllBaseClasses = foundAllBaseClasses;
     if (foundAllBaseClasses) //If we've seen all the base classes and none of the above were true then it must not be virtual
         return false;
-    return defaultVal; //If we can't see all the bases classes then we can't say conclusively
+    //If we can't see all the bases classes then we can't say conclusively, set inconclusive (if possible) and return default value
+    if (inconclusive)
+        *inconclusive = true;
+    return defaultVal;
 }
 
 std::vector<const Function*> Function::getOverloadedFunctions() const

lib/symboldatabase.h

@@ -783,7 +783,7 @@ class CPPCHECKLIB Function {
     void addArguments(const Scope *scope);
 
     /** @brief check if this function is virtual in the base classes */
-    bool isImplicitlyVirtual(bool defaultVal = false, bool* pFoundAllBaseClasses = nullptr) const;
+    bool isImplicitlyVirtual(bool defaultVal = false, bool* pFoundAllBaseClasses = nullptr, bool* inconclusive = nullptr) const;
 
     std::vector<const Function*> getOverloadedFunctions() const;