moved reading of UNUSEDFUNCTION_ONLY into a single place

Author: firewave

cli/cppcheckexecutor.cpp

@@ -347,8 +347,7 @@ bool CppCheckExecutor::reportUnmatchedSuppressions(const Settings &settings, con
 
     SuppressionList supprlist;
 
-    const char* unusedFunctionOnly = std::getenv("UNUSEDFUNCTION_ONLY");
-    const bool doUnusedFunctionOnly = unusedFunctionOnly && (std::strcmp(unusedFunctionOnly, "1") == 0);
+    const bool doUnusedFunctionOnly = Settings::doUnusedFunctionOnly();
     // ignore all other suppressions if we use the unusedFunction hack
     for (auto&& s : suppr)
     {

lib/cppcheck.cpp

@@ -1340,8 +1340,7 @@ void CppCheck::checkNormalTokens(const Tokenizer &tokenizer, AnalyzerInformation
 
     // TODO: this should actually be the behavior if only "--enable=unusedFunction" is specified - see #10648
     // TODO: log message when this is active?
-    const char* unusedFunctionOnly = std::getenv("UNUSEDFUNCTION_ONLY");
-    const bool doUnusedFunctionOnly = unusedFunctionOnly && (std::strcmp(unusedFunctionOnly, "1") == 0);
+    const bool doUnusedFunctionOnly = Settings::doUnusedFunctionOnly();
 
     if (!doUnusedFunctionOnly) {
         const std::time_t maxTime = mSettings.checksMaxTime > 0 ? std::time(nullptr) + mSettings.checksMaxTime : 0;

lib/settings.cpp

@@ -715,3 +715,9 @@ Settings::ExecutorType Settings::defaultExecutor()
 #endif
     return defaultExecutor;
 }
+
+bool Settings::doUnusedFunctionOnly()
+{
+    const char* unusedFunctionOnly = std::getenv("UNUSEDFUNCTION_ONLY");
+    return unusedFunctionOnly && (std::strcmp(unusedFunctionOnly, "1") == 0);
+}

lib/settings.h

@@ -554,9 +554,10 @@ class CPPCHECKLIB WARN_UNUSED Settings {
 
     void setCheckLevel(CheckLevel level);
 
-
     static ExecutorType defaultExecutor();
 
+    static bool doUnusedFunctionOnly();
+
 private:
     static std::string parseEnabled(const std::string &str, std::tuple<SimpleEnableGroup<Severity>, SimpleEnableGroup<Checks>> &groups);
     std::string applyEnabled(const std::string &str, bool enable);