mitigated bugprone-exception-escape clang-tidy warnings

Author: firewave

gui/main.cpp

@@ -45,6 +45,7 @@ static void ShowUsage();
 static void ShowVersion();
 static bool CheckArgs(const QStringList &args);
 
+// NOLINTNEXTLINE(bugprone-exception-escape) - reported with libc++ only
 int main(int argc, char *argv[])
 {
     QApplication app(argc, argv);

lib/ctu.h

@@ -109,6 +109,7 @@ namespace CTU {
             bool loadBaseFromXml(const tinyxml2::XMLElement *xmlElement);
         };
 
+        // NOLINTNEXTLINE(bugprone-exception-escape) - reported with libc++ only
         class FunctionCall : public CallBase {
         public:
             std::string callArgumentExpression;
@@ -121,6 +122,7 @@ namespace CTU {
             bool loadFromXml(const tinyxml2::XMLElement *xmlElement);
         };
 
+        // NOLINTNEXTLINE(bugprone-exception-escape) - reported with libc++ only
         class NestedCall : public CallBase {
         public:
             NestedCall() = default;

lib/importproject.cpp

@@ -935,7 +935,7 @@ bool ImportProject::importVcxproj(const std::string &filename, const tinyxml2::X
 
 ImportProject::SharedItemsProject ImportProject::importVcxitems(const std::string& filename, const std::vector<std::string>& fileFilters, std::vector<SharedItemsProject> &cache)
 {
-    auto isInCacheCheck = [filename](const ImportProject::SharedItemsProject& e) -> bool {
+    auto isInCacheCheck = [&filename](const ImportProject::SharedItemsProject& e) -> bool {
         return filename == e.pathToProjectFile;
     };
     const auto iterator = std::find_if(cache.begin(), cache.end(), isInCacheCheck);

lib/templatesimplifier.cpp

@@ -74,6 +74,7 @@ namespace {
         const Token * const mToken;
     };
 
+    // NOLINTNEXTLINE(bugprone-exception-escape) - reported with libc++ only
     class FindName {
     public:
         explicit FindName(std::string name) : mName(std::move(name)) {}
@@ -84,6 +85,7 @@ namespace {
         const std::string mName;
     };
 
+    // NOLINTNEXTLINE(bugprone-exception-escape) - reported with libc++ only
     class FindFullName {
     public:
         explicit FindFullName(std::string fullName) : mFullName(std::move(fullName)) {}

lib/tokenlist.cpp

@@ -1883,6 +1883,7 @@ namespace {
     struct OnException {
         std::function<void()> f;
 
+        // NOLINTNEXTLINE(bugprone-exception-escape) - reported with libc++ only
         ~OnException() {
 #ifndef _MSC_VER
 #if defined(__cpp_lib_uncaught_exceptions)

lib/utils.h

@@ -54,6 +54,7 @@ struct SelectMapValues {
 struct OnExit {
     std::function<void()> f;
 
+    // NOLINTNEXTLINE(bugprone-exception-escape) - reported with libc++ for any files which includes this (even if not used)
     ~OnExit() {
         f();
     }

tools/dmake/dmake.cpp

@@ -433,6 +433,7 @@ static void write_ossfuzz_makefile(std::vector<std::string> libfiles_prio, std::
     fout << "\t$(CXX) ${LIB_FUZZING_ENGINE} $(CPPFLAGS) $(CXXFLAGS) -DNO_FUZZ -c -o $@ main.cpp\n";
 }
 
+// NOLINTNEXTLINE(bugprone-exception-escape) - reported with libc++ only
 int main(int argc, char **argv)
 {
     const bool release(argc >= 2 && std::string(argv[1]) == "--release");