run clang-tidy with C++20

Author: firewave

.clang-tidy

@@ -43,15 +43,20 @@ Checks: >
         -modernize-deprecated-ios-base-aliases,
         -misc-include-cleaner,
         -misc-unused-using-decls,
+        -modernize-avoid-bind,
         -modernize-loop-convert,
         -modernize-macro-to-enum,
+        -modernize-make-unique,
         -modernize-raw-string-literal,
         -modernize-replace-auto-ptr,
         -modernize-return-braced-init-list,
         -modernize-type-traits,
+        -modernize-use-constraints,
         -modernize-use-designated-initializers,
         -modernize-use-nodiscard,
+        -modernize-use-ranges,
         -modernize-use-scoped-lock,
+        -modernize-use-starts-ends-with,
         -modernize-use-trailing-return-type,
         -performance-avoid-endl,
         -performance-inefficient-string-concatenation,
@@ -61,6 +66,7 @@ Checks: >
         -portability-std-allocator-const,
         -readability-avoid-nested-conditional-operator,
         -readability-braces-around-statements,
+        -readability-container-contains,
         -readability-container-data-pointer,
         -readability-enum-initial-value,
         -readability-function-cognitive-complexity,

.github/workflows/clang-tidy.yml

@@ -61,7 +61,7 @@ jobs:
 
       - name: Prepare CMake
         run: |
-          cmake -S . -B cmake.output -G "Unix Makefiles" -DHAVE_RULES=On -DBUILD_TESTS=On -DBUILD_GUI=On -DWITH_QCHART=On -DBUILD_TRIAGE=On -DENABLE_CHECK_INTERNAL=On -DCMAKE_GLOBAL_AUTOGEN_TARGET=On -DDISABLE_DMAKE=On -DCPPCHK_GLIBCXX_DEBUG=Off -DWARNINGS_ARE_ERRORS=On
+          cmake -S . -B cmake.output -G "Unix Makefiles" -DCMAKE_CXX_STANDARD=20 -DHAVE_RULES=On -DBUILD_TESTS=On -DBUILD_GUI=On -DWITH_QCHART=On -DBUILD_TRIAGE=On -DENABLE_CHECK_INTERNAL=On -DCMAKE_GLOBAL_AUTOGEN_TARGET=On -DDISABLE_DMAKE=On -DCPPCHK_GLIBCXX_DEBUG=Off -DWARNINGS_ARE_ERRORS=On
         env:
           CC: clang-22
           CXX: clang++-22

clang-tidy.md

@@ -133,6 +133,7 @@ Does not improve the readability.
 `misc-unconventional-assign-operator`<br/>
 `bugprone-throwing-static-initialization`<br/>
 `bugprone-command-processor`<br/>
+`modernize-use-nodiscard`<br/>
 
 To be evaluated (need to remove exclusion).
 
@@ -150,10 +151,15 @@ To be evaluated (need to remove exclusion).
 To be evaluated (need to enable explicitly).
 
 `modernize-type-traits`<br/>
-`modernize-use-nodiscard`<br/>
 `modernize-use-scoped-lock`<br/>
-
-These apply to codebases which use later standards then C++11 (C++17 is used when building with Qt6) so we cannot simply apply them.
+`modernize-use-constraints`<br/>
+`modernize-use-starts-ends-with`<br/>
+`modernize-avoid-bind`<br/>
+`modernize-make-unique`<br/>
+`modernize-use-ranges`<br/>
+`readability-container-contains`<br/>
+
+These require us to default to a later standard than C++11 so we cannot apply them.
 
 `portability-avoid-pragma-once`<br/>