Proper error reporting instead of "exit(-1)" call

Author: Felix Faber

lib/importproject.cpp

@@ -909,7 +909,13 @@ bool ImportProject::importVcxproj(const std::string& filename, std::map<std::str
                                 printError("Could not simplify path to referenced shared items project");
                                 exit(-1);
                             }
-                            sharedItemsProjects.emplace_back(importVcxitems(pathToSharedItemsFile, fileFilters, cache));
+                            SharedItemsProject toAdd = importVcxitems(pathToSharedItemsFile, fileFilters, cache);
+                            if (!toAdd.successFull)
+                            {
+                                printError("Could not load shared items project \"" + pathToSharedItemsFile + "\" from original path \"" + std::string(projectAttribute) + "\".");
+                                return false;
+                            }
+                            sharedItemsProjects.emplace_back(toAdd);
                         }
                     }
                 }
@@ -1015,12 +1021,12 @@ ImportProject::SharedItemsProject ImportProject::importVcxitems(const std::strin
     const tinyxml2::XMLError error = doc.LoadFile(filename.c_str());
     if (error != tinyxml2::XML_SUCCESS) {
         printError(std::string("Visual Studio project file is not a valid XML - ") + tinyxml2::XMLDocument::ErrorIDToName(error));
-        exit(-1);
+        return result;
     }
     const tinyxml2::XMLElement* const rootnode = doc.FirstChildElement();
     if (rootnode == nullptr) {
         printError("Visual Studio project file has no XML root node");
-        exit(-1);
+        return result;
     }
     for (const tinyxml2::XMLElement* node = rootnode->FirstChildElement(); node; node = node->NextSiblingElement()) {
         if (std::strcmp(node->Name(), "ItemGroup") == 0) {
@@ -1037,7 +1043,7 @@ ImportProject::SharedItemsProject ImportProject::importVcxitems(const std::strin
                         result.sourceFiles.emplace_back(file);
                     } else {
                         printError("Could not find shared items source file");
-                        exit(-1);
+                        return result;
                     }
                 }
             }
@@ -1053,6 +1059,7 @@ ImportProject::SharedItemsProject ImportProject::importVcxitems(const std::strin
         }
     }
 
+    result.successFull = true;
     cache.emplace_back(result);
     return result;
 }

lib/importproject.h

@@ -102,6 +102,7 @@ class CPPCHECKLIB WARN_UNUSED ImportProject {
 
 private:
     struct SharedItemsProject {
+        bool successFull;
         std::string pathToProjectFile;
         std::vector<std::string> includePaths;
         std::vector<std::string> sourceFiles;