fixed #14620 - add suppression for valgrind false positive

removed LSAN suppression

fixed #14619 - fixed potential memory leak using `--rule`

Author: firewave

.github/workflows/valgrind.yml

@@ -70,7 +70,7 @@ jobs:
             TestProcessExecutorFiles \
             TestSuppressions::suppressionsSettingsProcessesFiles \
             TestSuppressions::suppressionsSettingsProcessesFS"
-          valgrind --error-limit=yes --leak-check=full --num-callers=50 --show-reachable=yes --track-origins=yes --suppressions=valgrind/testrunner.supp --gen-suppressions=all --log-fd=9 --error-exitcode=42 ./testrunner -t -x $excluded_tests 9>memcheck.log || ec=1
+          valgrind --error-limit=yes --leak-check=full --num-callers=50 --show-reachable=yes --track-origins=yes --suppressions=valgrind/testrunner.supp --gen-suppressions=all -s --log-fd=9 --error-exitcode=42 ./testrunner -t -x $excluded_tests 9>memcheck.log || ec=1
           cat memcheck.log
           exit $ec
         # TODO: debuginfod.ubuntu.com is currently not responding to any requests causing it to run into a 40(!) minute timeout

lib/regex.cpp

@@ -167,7 +167,7 @@ namespace {
         ~PcreRegex() override
         {
             if (mExtra) {
-                pcre_free(mExtra);
+                pcre_free_study(mExtra);
                 mExtra = nullptr;
             }
             if (mRe) {

lsan-suppr.txt

@@ -14,3 +14,9 @@
    obj:*
    obj:*
 }
+{
+   TestRegEx::partialmatch false positive
+   Memcheck:Cond
+   obj:*
+   obj:*
+}