added some CI TODOs

Author: firewave

.github/workflows/CI-unixish.yml

@@ -174,6 +174,7 @@ jobs:
           pushd gui/help
           qhelpgenerator online-help.qhcp -o online-help.qhc
 
+      # TODO: make sure we always run all the checks so all issues are exposed at once and not incrementally
       # Run self check after "Build GUI" to include generated headers in analysis
       - name: Self check
         if: matrix.os == 'ubuntu-20.04'

.github/workflows/asan.yml

@@ -31,7 +31,9 @@ jobs:
       - name: Run tests
         run: ./testrunner
 
-# Does not work
+# TODO: runs out of memory
+# TODO: we need to ignore the self-check failures and only fail on ASAN ones
+# TODO: make sure we always run all the checks so all issues are exposed at once and not incrementally
 #      - name: Self check
 #        run: |
 #          ./cppcheck -q -j$(nproc) --std=c++11 --template=selfcheck -D__CPPCHECK__ --error-exitcode=1 --inline-suppr --suppressions-list=.travis_suppressions --library=cppcheck-lib -Ilib -Iexternals/simplecpp/ -Iexternals/tinyxml2/ -Icli --inconclusive --enable=style,performance,portability,warning,internal --exception-handling --debug-warnings cli lib

.github/workflows/ubsan.yml

@@ -31,6 +31,8 @@ jobs:
       - name: Run tests
         run: ./testrunner
 
+      # TODO: we need to ignore the self-check failures and only fail on UBSAN ones
+      # TODO: make sure we always run all the checks so all issues are exposed at once and not incrementally
       - name: Self check
         run: |
           ./cppcheck -q -j$(nproc) --std=c++11 --template=selfcheck -D__CPPCHECK__ --error-exitcode=1 --inline-suppr --suppressions-list=.travis_suppressions --library=cppcheck-lib -Ilib -Iexternals/simplecpp/ -Iexternals/tinyxml2/ -Icli --inconclusive --enable=style,performance,portability,warning,internal --exception-handling --debug-warnings cli lib