Fix

Author: web-flow

lib/checkother.cpp

@@ -3339,13 +3339,11 @@ static bool checkVariableAssignment(const Token* tok, const Settings& settings)
         return false;
     if (isVariableChanged(var, settings))
         return false;
-    if (var->isMember()) {
-        const Scope* scope = tok->scope();
-        while (scope && scope->type != ScopeType::eFunction)
-            scope = scope->nestedIn;
-        if (!scope || !scope->function || (!scope->function->isConst() && !scope->function->isStatic()))
-            return false;
-    }
+    const Scope* scope = tok->scope();
+    while (scope && scope->type != ScopeType::eFunction)
+        scope = scope->nestedIn;
+    if (!scope || !scope->function || (scope->functionOf && !scope->function->isConst() && !scope->function->isStatic()))
+        return false;
     return true;
 }
 

test/testother.cpp

@@ -9899,6 +9899,17 @@ class TestOther : public TestFixture {
         ASSERT_EQUALS("[test.cpp:2:17]: (performance, inconclusive) Use const reference for 's1' to avoid unnecessary data copying. [redundantCopyLocalConst]\n"
                       "[test.cpp:7:17]: (performance, inconclusive) Use const reference for 's1' to avoid unnecessary data copying. [redundantCopyLocalConst]\n",
                       errout_str());
+
+        check("struct S {\n"
+              "    std::string m;\n"
+              "    int f(const std::string& s);\n"
+              "};\n"
+              "int S::f(const std::string& s) {\n"
+              "    std::string c = s;\n"
+              "    m.clear();\n"
+              "    return c.size();\n"
+              "}\n");
+        ASSERT_EQUALS("", errout_str());
     }
 
     void checkNegativeShift() {