enabled and fixed remaining -Wdeprecated-copy-dtor Clang compiler warnings (#4860)

Author: firewave

cmake/compileroptions.cmake

@@ -76,7 +76,6 @@ elseif (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
    add_compile_options_safe(-Wno-documentation-unknown-command)
 
    # TODO: fix and enable these warnings - or move to suppression list below
-   add_compile_options_safe(-Wno-deprecated-copy-dtor)
    add_compile_options_safe(-Wno-inconsistent-missing-destructor-override) # caused by Qt moc code
    add_compile_options_safe(-Wno-unused-exception-parameter)
    add_compile_options_safe(-Wno-old-style-cast)

gui/codeeditorstyle.h

@@ -67,7 +67,6 @@ class CodeEditorStyle {
         // cppcheck-suppress naming-varname - TODO: fix this
         QColor SymbFGColor, QColor SymbBGColor,
         const QFont::Weight& SymbWeight);
-    ~CodeEditorStyle() {}
 
     bool operator==(const CodeEditorStyle& rhs) const;
     bool operator!=(const CodeEditorStyle& rhs) const;