clang-tidy std::move ref

Author: danmar

gui/resultitem.cpp

@@ -19,5 +19,5 @@
 #include "resultitem.h"
 
 ResultItem::ResultItem(QSharedPointer<ErrorItem> errorItem, Type type, int errorPathIndex)
-    : errorItem(errorItem), mType(type), mErrorPathIndex(errorPathIndex)
+    : errorItem(std::move(errorItem)), mType(type), mErrorPathIndex(errorPathIndex)
 {}

gui/test/resultstree/testresultstree.cpp

@@ -136,16 +136,16 @@ void TestResultsTree::test1() const
 
 static QErrorPathItem createErrorPathItem(QString file, int line, int column, QString info) {
     QErrorPathItem ret;
-    ret.file = file;
+    ret.file = std::move(file);
     ret.line = line;
     ret.column = column;
-    ret.info = info;
+    ret.info = std::move(info);
     return ret;
 }
 
-static ErrorItem createErrorItem(QString file, int line, Severity sev, QString message, QString id) {
+static ErrorItem createErrorItem(const QString& file, int line, Severity sev, const QString& message, QString id) {
     ErrorItem ret;
-    ret.errorId = id;
+    ret.errorId = std::move(id);
     ret.severity = sev;
     ret.cwe = ret.hash = 0;
     ret.file0 = file;
@@ -199,7 +199,7 @@ void TestResultsTree::resultsInSameFile() const
     ResultsTree tree(nullptr);
     tree.addErrorItem(createErrorItem("file1.c", 10, Severity::style, "test", "bugId"));
     tree.addErrorItem(createErrorItem("file1.c", 20, Severity::style, "test", "bugId"));
-    QStandardItemModel* model = dynamic_cast<QStandardItemModel*>(tree.model());
+    auto* model = dynamic_cast<QStandardItemModel*>(tree.model());
     QVERIFY(model != nullptr);
     QVERIFY(model->rowCount() == 1);