Skip to content

Commit 8481b93

Browse files
committed
TestCmdlineParser: resolved bogus TODO asserts
1 parent e06e98f commit 8481b93

1 file changed

Lines changed: 10 additions & 12 deletions

File tree

test/testcmdlineparser.cpp

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -300,10 +300,10 @@ class TestCmdlineParser : public TestFixture {
300300
TEST_CASE(suppressionsNoFile1);
301301
TEST_CASE(suppressionsNoFile2);
302302
TEST_CASE(suppressionsNoFile3);
303-
TEST_CASE(suppressionSingle);
304-
TEST_CASE(suppressionSingleFile);
305-
TEST_CASE(suppressionTwo);
306-
TEST_CASE(suppressionTwoSeparate);
303+
TEST_CASE(suppressSingle);
304+
TEST_CASE(suppressSingleFile);
305+
TEST_CASE(suppressTwo);
306+
TEST_CASE(suppressTwoSeparate);
307307
TEST_CASE(templates);
308308
TEST_CASE(templatesGcc);
309309
TEST_CASE(templatesVs);
@@ -1956,30 +1956,28 @@ class TestCmdlineParser : public TestFixture {
19561956
return e;
19571957
}
19581958

1959-
void suppressionSingle() {
1959+
void suppressSingle() {
19601960
REDIRECT;
19611961
const char * const argv[] = {"cppcheck", "--suppress=uninitvar", "file.cpp"};
19621962
ASSERT_EQUALS_ENUM(CmdLineParser::Result::Success, parseFromArgs(argv));
19631963
ASSERT_EQUALS(true, supprs->nomsg.isSuppressed(errorMessage("uninitvar", "file.cpp", 1)));
19641964
}
19651965

1966-
void suppressionSingleFile() {
1966+
void suppressSingleFile() {
19671967
REDIRECT;
19681968
const char * const argv[] = {"cppcheck", "--suppress=uninitvar:file.cpp", "file.cpp"};
19691969
ASSERT_EQUALS_ENUM(CmdLineParser::Result::Success, parseFromArgs(argv));
19701970
ASSERT_EQUALS(true, supprs->nomsg.isSuppressed(errorMessage("uninitvar", "file.cpp", 1U)));
19711971
}
19721972

1973-
void suppressionTwo() {
1973+
void suppressTwo() {
19741974
REDIRECT;
19751975
const char * const argv[] = {"cppcheck", "--suppress=uninitvar,noConstructor", "file.cpp"};
1976-
TODO_ASSERT_EQUALS(static_cast<int>(CmdLineParser::Result::Success), static_cast<int>(CmdLineParser::Result::Fail), static_cast<int>(parseFromArgs(argv)));
1977-
TODO_ASSERT_EQUALS(true, false, supprs->nomsg.isSuppressed(errorMessage("uninitvar", "file.cpp", 1U)));
1978-
TODO_ASSERT_EQUALS(true, false, supprs->nomsg.isSuppressed(errorMessage("noConstructor", "file.cpp", 1U)));
1979-
TODO_ASSERT_EQUALS("", "cppcheck: error: Failed to add suppression. Invalid id \"uninitvar,noConstructor\"\n", logger->str());
1976+
ASSERT_EQUALS_ENUM(CmdLineParser::Result::Fail, parseFromArgs(argv));
1977+
ASSERT_EQUALS("cppcheck: error: Failed to add suppression. Invalid id \"uninitvar,noConstructor\"\n", logger->str());
19801978
}
19811979

1982-
void suppressionTwoSeparate() {
1980+
void suppressTwoSeparate() {
19831981
REDIRECT;
19841982
const char * const argv[] = {"cppcheck", "--suppress=uninitvar", "--suppress=noConstructor", "file.cpp"};
19851983
ASSERT_EQUALS_ENUM(CmdLineParser::Result::Success, parseFromArgs(argv));

0 commit comments

Comments
 (0)