review: enum

Author: danmar

lib/suppressions.cpp

@@ -806,47 +806,47 @@ std::vector<std::pair<std::string, std::string>> polyspace::Parser::parseFamilyR
     std::vector<std::pair<std::string, std::string>> fr;
     std::string family;
     std::string rule;
-    int state = 0; // 0=family, 1=colon, 2=rule, 3=rule/family
+    enum class State: uint8_t { family, colon, rule, rule_or_family } state = State::family;
     const std::string::size_type endpos = startsWith(comment, "/*") ? comment.size() - 2 : comment.size();
     for (; pos <= endpos; ++pos) {
         const char c = comment[pos];
         if (std::strchr("[\"", c))
             break;
         switch (state) {
-        case 0: // parse family
+        case State::family:
             if (std::isalnum(c) || std::strchr("-_.",c))
                 family += c;
             else if (!family.empty() && std::strchr(" \t:",c))
-                ++state;
+                state = State::colon;
             break;
-        case 1: // colon
+        case State::colon:
             if (!std::strchr(" \t:", c)) {
                 rule.clear();
                 --pos;
-                ++state;
+                state = State::rule;
             }
             break;
-        case 2: // rules
+        case State::rule:
             if (std::strchr(", \t",c)) {
                 if (!rule.empty()) {
                     fr.emplace_back(family,rule);
                     rule.clear();
                     if (c != ',')
-                        ++state;
+                        state = State::rule_or_family;
                 }
             }
             else
                 rule += c;
             break;
-        case 3: // rule/family
+        case State::rule_or_family:
             rule.clear();
             if (std::isalnum(c)) {
                 --pos;
                 family.clear();
-                state = 0; // family
+                state = State::family;
             } else if (c == ',') {
                 --pos;
-                state = 2; // rule
+                state = State::rule;
             }
             break;
         }