make ci happy

Author: Leander Schulten

.github/workflows/selfcheck.yml

@@ -121,7 +121,7 @@ jobs:
 
       - name: Self check (unusedFunction / no test / no gui)
         run: |
-          supprs="--suppress=unusedFunction:lib/errorlogger.h:196 --suppress=unusedFunction:lib/importproject.cpp:1673 --suppress=unusedFunction:lib/importproject.cpp:1697"
+          supprs="--suppress=unusedFunction:lib/errorlogger.h:197 --suppress=unusedFunction:lib/importproject.cpp:1660 --suppress=unusedFunction:lib/importproject.cpp:1684"
           ./cppcheck -q --template=selfcheck --error-exitcode=1 --library=cppcheck-lib -D__CPPCHECK__ -D__GNUC__ --enable=unusedFunction,information --exception-handling -rp=. --project=cmake.output.notest_nogui/compile_commands.json --suppressions-list=.selfcheck_unused_suppressions --inline-suppr $supprs
         env:
           DISABLE_VALUEFLOW: 1

lib/importproject.cpp

@@ -692,7 +692,7 @@ namespace {
             if (tok->str() == "||")
                 return boolResult(executeOp1(tok, p) == "True" || executeOp2(tok, p) == "True");
             if (tok->str() == "(" && Token::Match(tok->previous(), "$ ( %name% . %name% (")) {
-                const std::string propertyName = tok->next()->str();
+                const std::string& propertyName = tok->strAt(1);
                 std::string propertyValue;
                 if (propertyName == "Configuration")
                     propertyValue = p.configuration;
@@ -1706,6 +1706,5 @@ bool cppcheck::testing::evaluateVcxprojCondition(const std::string& condition, c
     ProjectConfiguration p;
     p.configuration = configuration;
     p.platformStr = platform;
-    std::vector<std::string> errors;
     return ConditionalGroup::evalCondition(condition, p);
 }