test

Author: danmar

lib/cppcheck.cpp

@@ -1060,6 +1060,9 @@ unsigned int CppCheck::checkInternal(const FileWithDetails& file, const std::str
             for (const std::string &config : configurations)
                 (void)preprocessor.getcode(config, files, false);
 
+            if (configurations.size() > mSettings.maxConfigs)
+                tooManyConfigsError(Path::toNativeSeparators(file.spath()), configurations.size());
+
             if (analyzerInformation)
                 mLogger->setAnalyzerInfo(nullptr);
             return 0;
@@ -1079,7 +1082,9 @@ unsigned int CppCheck::checkInternal(const FileWithDetails& file, const std::str
         }
 #endif
 
-        if (!mSettings.force && configurations.size() > mSettings.maxConfigs &&
+        if (!mSettings.force &&
+            configurations.size() > mSettings.maxConfigs &&
+            mSettings.maxConfigs == 12 && // <- do not warn if maxConfigs has been changed
             mSettings.severity.isEnabled(Severity::information))
             tooManyConfigsError(Path::toNativeSeparators(file.spath()), configurations.size());
 

test/cli/other_test.py

@@ -3847,3 +3847,28 @@ def test_unmatched_file(tmp_path):  # #14248 / #14249
         f'{lib_file}:-1:0: information: Unmatched suppression: error6 [unmatchedSuppression]'
     ]
     assert ret == 0, stdout
+
+
+def test_max_configs(tmp_path):
+    test_file = tmp_path / 'test.cpp'
+    with open(test_file, "w") as f:
+        for i in range(1,20):
+            dir = 'if' if i == 1 else 'elif'
+            f.write(f'#{dir} defined(X{i})\nx = {i};\n')
+        f.write('#endif\n')
+
+    # default max configs is set to 12
+    _, stdout, stderr = cppcheck(['-v', '--enable=information', '--template=daca2', str(test_file)])
+    assert stderr.splitlines() == [
+        '{}:0:0: information: Too many #ifdef configurations - cppcheck only checks 12 of 20 configurations. Use --force to check all configurations. [toomanyconfigs]'.format(test_file)
+    ]
+
+    # set explicit max configs => do not warn
+    _, _, stderr = cppcheck(['--enable=information', '--template=daca2', '--max-configs=6', str(test_file)])
+    assert stderr.splitlines() == []
+
+    # when using --check-configs, warn
+    _, _, stderr = cppcheck(['--check-config', '--template=daca2', '--max-configs=6', str(test_file)])
+    assert stderr.splitlines() == [
+        '{}:0:0: information: Too many #ifdef configurations - cppcheck only checks 6 of 20 configurations. Use --force to check all configurations. [toomanyconfigs]'.format(test_file)
+    ]