Pass slot parameters by value

Author: danmar

gui/checkthread.h

@@ -49,7 +49,6 @@ class ThreadResult;
  */
 class CheckThread : public QThread {
     Q_OBJECT
-
 public:
     struct Details {
         int threadIndex;
@@ -111,8 +110,8 @@ class CheckThread : public QThread {
      */
     void done();
 
-    void startCheck(const CheckThread::Details& details);
-    void finishCheck(const CheckThread::Details& details);
+    void startCheck(CheckThread::Details details);
+    void finishCheck(CheckThread::Details details);
 protected:
 
     /**
@@ -160,5 +159,6 @@ class CheckThread : public QThread {
     QStringList mClangIncludePaths;
     QList<SuppressionList::Suppression> mSuppressionsUi;
 };
+Q_DECLARE_METATYPE(CheckThread::Details);
 /// @}
 #endif // CHECKTHREAD_H

gui/threaddetails.cpp

@@ -22,7 +22,7 @@ ThreadDetails::~ThreadDetails()
     delete mUi;
 }
 
-void ThreadDetails::threadDetailsUpdated(const QMap<int, CheckThread::Details>& threadDetails)
+void ThreadDetails::threadDetailsUpdated(QMap<int, CheckThread::Details> threadDetails)
 {
     QMutexLocker locker(&mMutex);
     mThreadDetails = threadDetails;
@@ -31,7 +31,7 @@ void ThreadDetails::threadDetailsUpdated(const QMap<int, CheckThread::Details>&
     }
 }
 
-void ThreadDetails::progress(const QString &filename, const QString& stage, const std::size_t value) {
+void ThreadDetails::progress(QString filename, QString stage, const std::size_t value) {
     QMutexLocker locker(&mMutex);
     mProgress[filename] = {QString(), stage + QString(value > 0 ? ": %1%" : "").arg(value)};
 }

gui/threaddetails.h

@@ -24,8 +24,8 @@ class ThreadDetails : public QWidget
     }
 
 public slots:
-    void threadDetailsUpdated(const QMap<int, CheckThread::Details>& threadDetails);
-    void progress(const QString &filename, const QString& stage, const std::size_t value);
+    void threadDetailsUpdated(QMap<int, CheckThread::Details> threadDetails);
+    void progress(QString filename, QString stage, const std::size_t value);
 
 private slots:
     void updateUI();

gui/threadhandler.cpp

@@ -331,14 +331,14 @@ void ThreadHandler::setCheckStartTime(QDateTime checkStartTime)
 
 // cppcheck-suppress passedByValueCallback
 // NOLINTNEXTLINE(performance-unnecessary-value-param)
-void ThreadHandler::startCheck(const CheckThread::Details& details)
+void ThreadHandler::startCheck(CheckThread::Details details)
 {
     mThreadDetails[details.threadIndex] = details;
     emitThreadDetailsUpdated();
 }
 
 // NOLINTNEXTLINE(performance-unnecessary-value-param)
-void ThreadHandler::finishCheck(const CheckThread::Details& details)
+void ThreadHandler::finishCheck(CheckThread::Details details)
 {
     mThreadDetails.remove(details.threadIndex);
     emitThreadDetailsUpdated();

gui/threadhandler.h

@@ -213,16 +213,16 @@ public slots:
      * @brief Slot threads use to signal this class that it started checking a file
      * @param details Details about what file is being checked and by what thread
      */
-    void startCheck(const CheckThread::Details& details);
+    void startCheck(CheckThread::Details details);
 
     /**
      * @brief Slot threads use to signal this class that it finish checking a file
      * @param details Details about what file finished being checked and by what thread
      */
-    void finishCheck(const CheckThread::Details& details);
+    void finishCheck(CheckThread::Details details);
 
 signals:
-    void progress(const QString &filename, const QString& stage, const std::size_t value);
+    void progress(QString filename, QString stage, const std::size_t value);
 
 protected slots:
     /**

gui/threadresult.cpp

@@ -35,7 +35,7 @@ void ThreadResult::reportOut(const std::string &outmsg, Color /*c*/)
 }
 
 // NOLINTNEXTLINE(performance-unnecessary-value-param)
-void ThreadResult::finishCheck(const CheckThread::Details& details)
+void ThreadResult::finishCheck(CheckThread::Details details)
 {
     std::lock_guard<std::mutex> locker(mutex);
 

gui/threadresult.h

@@ -92,7 +92,7 @@ public slots:
      * @brief Slot threads use to signal this class that it finish checking a file
      * @param details Details about what file finished being checked and by what thread
      */
-    void finishCheck(const CheckThread::Details& details);
+    void finishCheck(CheckThread::Details details);
 
 signals:
     /**
@@ -127,7 +127,7 @@ public slots:
     // NOLINTNEXTLINE(readability-inconsistent-declaration-parameter-name) - caused by generated MOC code
     void debugError(const ErrorItem &item);
 
-    void progress(const QString &filename, const QString& stage, const std::size_t value);
+    void progress(QString filename, QString stage, const std::size_t value);
 
 protected: