note that it ok get get an result for an invalid expression

Leander Schulten · Leander Schulten · commit 97490327b693 · 2026-04-10T16:15:13.000+02:00
diff --git a/test/testimportproject.cpp b/test/testimportproject.cpp
@@ -710,7 +710,8 @@ class TestImportProject : public TestFixture {
         ASSERT_THROW_EQUALS(cppcheck::testing::evaluateVcxprojCondition("''", "", ""), std::runtime_error, "Invalid condition: ''''");
         ASSERT_THROW_EQUALS(cppcheck::testing::evaluateVcxprojCondition("'' == '", "", ""), std::runtime_error, "Can not tokenize condition");
         ASSERT_THROW_EQUALS(cppcheck::testing::evaluateVcxprojCondition("$(Configuration.Lower())", "", ""), std::runtime_error, "Missing operator");
-        ASSERT_THROW_EQUALS(cppcheck::testing::evaluateVcxprojCondition("' ' && ' '", "", ""), std::runtime_error, "Missing operator");
+        // invalid expression in => no error. We are ok with that as long as we don't crash
+        ASSERT(!cppcheck::testing::evaluateVcxprojCondition("' ' && ' '", "", ""));
     }
 
     // TODO: test fsParseCommand()

Original file line number	Diff line number	Diff line change
`@@ -710,7 +710,8 @@ class TestImportProject : public TestFixture {`
`710`	`710`	`ASSERT_THROW_EQUALS(cppcheck::testing::evaluateVcxprojCondition("''", "", ""), std::runtime_error, "Invalid condition: ''''");`
`711`	`711`	`ASSERT_THROW_EQUALS(cppcheck::testing::evaluateVcxprojCondition("'' == '", "", ""), std::runtime_error, "Can not tokenize condition");`
`712`	`712`	`ASSERT_THROW_EQUALS(cppcheck::testing::evaluateVcxprojCondition("$(Configuration.Lower())", "", ""), std::runtime_error, "Missing operator");`
`713`		`- ASSERT_THROW_EQUALS(cppcheck::testing::evaluateVcxprojCondition("' ' && ' '", "", ""), std::runtime_error, "Missing operator");`
	`713`	`+ // invalid expression in => no error. We are ok with that as long as we don't crash`
	`714`	`+ ASSERT(!cppcheck::testing::evaluateVcxprojCondition("' ' && ' '", "", ""));`
`714`	`715`	`}`
`715`	`716`
`716`	`717`	`// TODO: test fsParseCommand()`