MISRA: Speed up analysis of .ctu_info files (#4666)

* Speed up analyses of .ctu_info files
Use temporary dictionaries to eliminate duplicate typedefs,
tags and macros

* Consistency: use a cache key variable
Ensures that the get and add use the same key.

* CTU perf: use dict for macros, tags & types.

Author: adbancroft

addons/misra.py

@@ -4435,9 +4435,9 @@ def fillVerifyExpected(verify_expected, tok):
             self.executeCheck(2210, self.misra_22_10, cfg)
 
     def analyse_ctu_info(self, ctu_info_files):
-        all_typedef_info = []
-        all_tagname_info = []
-        all_macro_info = []
+        all_typedef_info = {}
+        all_tagname_info = {}
+        all_macro_info = {}
         all_external_identifiers_decl = {}
         all_external_identifiers_def = {}
         all_internal_identifiers = {}
@@ -4461,47 +4461,38 @@ def is_different_location(loc1, loc2):
 
                     if summary_type == 'MisraTypedefInfo':
                         for new_typedef_info in summary_data:
-                            found = False
-                            for old_typedef_info in all_typedef_info:
-                                if old_typedef_info['name'] == new_typedef_info['name']:
-                                    found = True
-                                    if is_different_location(old_typedef_info, new_typedef_info):
-                                        self.reportError(Location(old_typedef_info), 5, 6)
-                                        self.reportError(Location(new_typedef_info), 5, 6)
-                                    else:
-                                        if new_typedef_info['used']:
-                                            old_typedef_info['used'] = True
-                                    break
-                            if not found:
-                                all_typedef_info.append(new_typedef_info)
+                            key = new_typedef_info['name']
+                            existing_typedef_info = all_typedef_info.get(key, None)
+                            if existing_typedef_info:
+                                if is_different_location(existing_typedef_info, new_typedef_info):
+                                    self.reportError(Location(existing_typedef_info), 5, 6)
+                                    self.reportError(Location(new_typedef_info), 5, 6)
+                                else:
+                                    existing_typedef_info['used'] = existing_typedef_info['used'] or new_typedef_info['used']
+                            else:
+                                all_typedef_info[key] = new_typedef_info
 
                     if summary_type == 'MisraTagName':
                         for new_tagname_info in summary_data:
-                            found = False
-                            for old_tagname_info in all_tagname_info:
-                                if old_tagname_info['name'] == new_tagname_info['name']:
-                                    found = True
-                                    if is_different_location(old_tagname_info, new_tagname_info):
-                                        self.reportError(Location(old_tagname_info), 5, 7)
-                                        self.reportError(Location(new_tagname_info), 5, 7)
-                                    else:
-                                        if new_tagname_info['used']:
-                                            old_tagname_info['used'] = True
-                                    break
-                            if not found:
-                                all_tagname_info.append(new_tagname_info)
+                            key = new_tagname_info['name']
+                            existing_tagname_info = all_tagname_info.get(key, None)
+                            if existing_tagname_info:
+                                if is_different_location(existing_tagname_info, new_tagname_info):
+                                    self.reportError(Location(existing_tagname_info), 5, 7)
+                                    self.reportError(Location(new_tagname_info), 5, 7)
+                                else:
+                                    existing_tagname_info['used'] = existing_tagname_info['used'] or new_tagname_info['used']
+                            else:
+                                all_tagname_info[key] = new_tagname_info
 
                     if summary_type == 'MisraMacro':
                         for new_macro in summary_data:
-                            found = False
-                            for old_macro in all_macro_info:
-                                if old_macro['name'] == new_macro['name']:
-                                    found = True
-                                    if new_macro['used']:
-                                        old_macro['used'] = True
-                                    break
-                            if not found:
-                                all_macro_info.append(new_macro)
+                            key = new_macro['name']
+                            existing_macro = all_macro_info.get(key, None)
+                            if existing_macro:
+                                existing_macro['used'] = existing_macro['used'] or new_macro['used']
+                            else:
+                                all_macro_info[key] = new_macro
 
                     if summary_type == 'MisraExternalIdentifiers':
                         for s in summary_data:
@@ -4540,17 +4531,17 @@ def is_different_location(loc1, loc2):
         except FileNotFoundError:
             return
 
-        for ti in all_typedef_info:
-            if not ti['used']:
-                self.reportError(Location(ti), 2, 3)
+        unused_typedefs = [tdi for tdi in all_typedef_info.values() if not tdi['used']]
+        for tdi in unused_typedefs:
+            self.reportError(Location(tdi), 2, 3)
 
-        for ti in all_tagname_info:
-            if not ti['used']:
-                self.reportError(Location(ti), 2, 4)
+        unused_tags = [tag for tag in all_tagname_info.values() if not tag['used']]
+        for tag in unused_tags:
+            self.reportError(Location(tag), 2, 4)
 
-        for m in all_macro_info:
-            if not m['used']:
-                self.reportError(Location(m), 2, 5)
+        unused_macros = [m for m in all_macro_info.values() if not m['used']]
+        for m in unused_macros:
+            self.reportError(Location(m), 2, 5)
 
         all_external_identifiers = all_external_identifiers_decl
         all_external_identifiers.update(all_external_identifiers_def)