fixed #13432 - do not generate (incomplete) dump files with --check-config (#7108)

Author: firewave

lib/cppcheck.cpp

@@ -1011,18 +1011,6 @@ unsigned int CppCheck::checkFile(const FileWithDetails& file, const std::string
             }
         }
 
-        FilesDeleter filesDeleter;
-
-        // write dump file xml prolog
-        std::ofstream fdump;
-        std::string dumpFile;
-        createDumpFile(mSettings, file, fdump, dumpFile);
-        if (fdump.is_open()) {
-            fdump << dumpProlog;
-            if (!mSettings.dump)
-                filesDeleter.addFile(dumpFile);
-        }
-
         // Get directives
         std::list<Directive> directives = preprocessor.createDirectives(tokens1);
         preprocessor.simplifyPragmaAsm(tokens1);
@@ -1072,6 +1060,18 @@ unsigned int CppCheck::checkFile(const FileWithDetails& file, const std::string
             }
         }
 
+        FilesDeleter filesDeleter;
+
+        // write dump file xml prolog
+        std::ofstream fdump;
+        std::string dumpFile;
+        createDumpFile(mSettings, file, fdump, dumpFile);
+        if (fdump.is_open()) {
+            fdump << dumpProlog;
+            if (!mSettings.dump)
+                filesDeleter.addFile(dumpFile);
+        }
+
         std::set<unsigned long long> hashes;
         int checkCount = 0;
         bool hasValidConfig = false;
@@ -1238,6 +1238,7 @@ unsigned int CppCheck::checkFile(const FileWithDetails& file, const std::string
             mErrorLogger.reportErr(errmsg);
         }
 
+        // TODO: will not be closed if we encountered an exception
         // dumped all configs, close root </dumps> element now
         if (fdump.is_open()) {
             fdump << "</dumps>" << std::endl;

test/cli/other_test.py

@@ -2465,4 +2465,27 @@ def test_undef_src(tmp_path):  # #13340
     ]
     assert stderr.splitlines() == [
         '{}:7:16: error: Null pointer dereference: (int*)0 [nullPointer]'.format(test_file)
-    ]
+    ]
+
+
+def test_dump_check_config(tmp_path):  # #13432
+    test_file = tmp_path / 'test.c'
+    with open(test_file, 'wt') as f:
+        f.write("""
+void f() {}
+""")
+
+    args = [
+        '-q',
+        '--template=simple',
+        '--dump',
+        '--check-config',
+        str(test_file)
+    ]
+    exitcode, stdout, stderr = cppcheck(args)
+    assert exitcode == 0, stdout
+    assert stdout == ''
+    assert stderr == ''
+
+    # no dump file should have been generated
+    assert not os.path.exists(str(test_file) + '.dump')