Set thread index in constructor

Author: ludviggunne

gui/checkthread.cpp

@@ -105,8 +105,9 @@ int CheckThread::executeCommand(std::string exe, std::vector<std::string> args,
 }
 
 
-CheckThread::CheckThread(ThreadResult &result) :
-    mResult(result)
+CheckThread::CheckThread(ThreadResult &result, int index)
+    : mResult(result)
+    , mThreadIndex(index)
 {}
 
 void CheckThread::setSettings(const Settings &settings, std::shared_ptr<Suppressions> supprs)
@@ -498,7 +499,3 @@ QString CheckThread::clangTidyCmd()
     return QString();
 }
 
-void CheckThread::setThreadIndex(int index)
-{
-    mThreadIndex = index;
-}

gui/checkthread.h

@@ -58,7 +58,7 @@ class CheckThread : public QThread {
     };
 
 public:
-    explicit CheckThread(ThreadResult &result);
+    CheckThread(ThreadResult &result, int index);
 
     /**
      * @brief Set settings for cppcheck
@@ -89,8 +89,6 @@ class CheckThread : public QThread {
 
     void stop();
 
-    void setThreadIndex(int index);
-
     /**
      * Determine command to run clang
      * \return Command to run clang, empty if it is not found

gui/threadhandler.cpp

@@ -146,8 +146,7 @@ void ThreadHandler::createThreads(const int count)
     removeThreads();
     //Create new threads
     for (int i = mThreads.size(); i < count; i++) {
-        mThreads << new CheckThread(mResults);
-        mThreads.last()->setThreadIndex(i + 1);
+        mThreads << new CheckThread(mResults, i + 1);
         connect(mThreads.last(), &CheckThread::done,
                 this, &ThreadHandler::threadDone, Qt::QueuedConnection);
         connect(mThreads.last(), &CheckThread::finishCheck,