selfcheck

Author: danmar

gui/threaddetails.cpp

@@ -18,7 +18,7 @@ ThreadDetails::~ThreadDetails()
     delete mUi;
 }
 
-void ThreadDetails::threadDetailsUpdated(QMap<int, CheckThread::Details> threadDetails)
+void ThreadDetails::threadDetailsUpdated(const QMap<int, CheckThread::Details>& threadDetails)
 {
     QString text("Thread\tStart time\tFile\n");
     for (const auto& td: threadDetails) {

gui/threaddetails.h

@@ -22,7 +22,7 @@ class ThreadDetails : public QWidget
     }
 
 public slots:
-    void threadDetailsUpdated(QMap<int, CheckThread::Details> threadDetails);
+    void threadDetailsUpdated(const QMap<int, CheckThread::Details>& threadDetails);
 
 private:
     static ThreadDetails* mInstance;

gui/threadhandler.cpp

@@ -328,14 +328,14 @@ void ThreadHandler::setCheckStartTime(QDateTime checkStartTime)
 
 // cppcheck-suppress passedByValueCallback
 // NOLINTNEXTLINE(performance-unnecessary-value-param)
-void ThreadHandler::startCheck(CheckThread::Details details)
+void ThreadHandler::startCheck(const CheckThread::Details& details)
 {
     mThreadDetails[details.threadIndex] = details;
     emitThreadDetailsUpdated();
 }
 
 // NOLINTNEXTLINE(performance-unnecessary-value-param)
-void ThreadHandler::finishCheck(CheckThread::Details details)
+void ThreadHandler::finishCheck(const CheckThread::Details& details)
 {
     mThreadDetails.remove(details.threadIndex);
     emitThreadDetailsUpdated();

gui/threadhandler.h

@@ -213,13 +213,13 @@ public slots:
      * @brief Slot threads use to signal this class that it started checking a file
      * @param details Details about what file is being checked and by what thread
      */
-    void startCheck(CheckThread::Details details);
+    void startCheck(const CheckThread::Details& details);
 
     /**
      * @brief Slot threads use to signal this class that it finish checking a file
      * @param details Details about what file finished being checked and by what thread
      */
-    void finishCheck(CheckThread::Details details);
+    void finishCheck(const CheckThread::Details& details);
 
 protected slots:
     /**

gui/threadresult.cpp

@@ -35,7 +35,7 @@ void ThreadResult::reportOut(const std::string &outmsg, Color /*c*/)
 }
 
 // NOLINTNEXTLINE(performance-unnecessary-value-param)
-void ThreadResult::finishCheck(CheckThread::Details details)
+void ThreadResult::finishCheck(const CheckThread::Details& details)
 {
     std::lock_guard<std::mutex> locker(mutex);
 

gui/threadresult.h

@@ -91,13 +91,13 @@ public slots:
      * @brief Slot threads use to signal this class that it finish checking a file
      * @param details Details about what file finished being checked and by what thread
      */
-    void finishCheck(CheckThread::Details details);
+    void finishCheck(const CheckThread::Details& details);
 
 signals:
     /**
-     * @brief Progress signal
-     * @param value Current progress
-     * @param description Description of the current stage
+     * @brief Files checked progress
+     * @param value Current progress (0 - PROGRESS_MAX)
+     * @param description Description of the current stage (example: 13/45 files checked)
      */
     // NOLINTNEXTLINE(readability-inconsistent-declaration-parameter-name) - caused by generated MOC code
     void progress(int value, const QString& description);