ainfo

Author: firewave

cli/cppcheckexecutor.cpp

@@ -361,21 +361,11 @@ bool CppCheckExecutor::reportUnmatchedSuppressions(const Settings &settings, con
         supprlist.addSuppression(std::move(s));
     }
 
-    const auto reportErrorsFn = [&](const std::string& sourcefile, std::size_t fsFileId, const std::vector<ErrorMessage>& errors) -> bool {
+    const auto reportErrorsFn = [&](const std::vector<ErrorMessage>& errors) -> bool {
         if (errors.empty())
             return false;
 
-        // TODO: what if sourcefile is empty?
-
-        AnalyzerInformation analyzerInfo;
-        // FIXME: this is a horrible hack
-        // we need to "re-open" the file so we can add the unmatchedSuppression findings.
-        // we cannot keep it open conditionally because the whole program analysis reads the XML.
-        // re-ordering the code is also not an option because the unmatched suppression reporting needs to be run after all other checks.
-        analyzerInfo.reopen(settings.buildDir, sourcefile, /*cfgname*/ "", fsFileId);
-
         for (const auto& errmsg : errors) {
-            analyzerInfo.reportErr(errmsg);
             errorLogger.reportErr(errmsg);
         }
         return true;
@@ -385,30 +375,24 @@ bool CppCheckExecutor::reportUnmatchedSuppressions(const Settings &settings, con
 
     for (auto i = files.cbegin(); i != files.cend(); ++i) {
         const std::vector<ErrorMessage> errors = getUnmatchedSuppressions(supprlist.getUnmatchedLocalSuppressions(*i), settings.unmatchedSuppressionFilters);
-        err |= reportErrorsFn(i->spath(), i->fsFileId(), errors);
+        err |= reportErrorsFn(errors);
     }
 
     for (auto i = fileSettings.cbegin(); i != fileSettings.cend(); ++i) {
         const std::vector<ErrorMessage> errors = getUnmatchedSuppressions(supprlist.getUnmatchedLocalSuppressions(i->file), settings.unmatchedSuppressionFilters);
-        err |= reportErrorsFn(i->file.spath(), i->file.fsFileId(), errors);
+        err |= reportErrorsFn(errors);
     }
 
     if (settings.inlineSuppressions) {
         const std::vector<ErrorMessage> errors = getUnmatchedSuppressions(supprlist.getUnmatchedInlineSuppressions(), settings.unmatchedSuppressionFilters);
         for (const auto& errmsg : errors) {
-            std::string sourcefile;
-            if (!errmsg.callStack.empty())
-                sourcefile = errmsg.callStack.cbegin()->getfile(false); // TODO: simplify path?
-            err |= reportErrorsFn(sourcefile, 0, {errmsg});
+            err |= reportErrorsFn({errmsg});
         }
     }
 
     const std::vector<ErrorMessage> errors = getUnmatchedSuppressions(supprlist.getUnmatchedGlobalSuppressions(), settings.unmatchedSuppressionFilters);
     for (const auto& errmsg : errors) {
-        std::string sourcefile;
-        if (!errmsg.callStack.empty())
-            sourcefile = errmsg.callStack.cbegin()->getfile(false); // TODO: simplify path?
-        err |= reportErrorsFn(sourcefile, 0, {errmsg});
+        err |= reportErrorsFn({errmsg});
     }
     return err;
 }

lib/analyzerinfo.cpp

@@ -293,24 +293,3 @@ std::string AnalyzerInformation::processFilesTxt(const std::string& buildDir, co
     // TODO: error on empty file?
     return "";
 }
-
-void AnalyzerInformation::reopen(const std::string &buildDir, const std::string &sourcefile, const std::string &cfg, std::size_t fsFileId)
-{
-    if (buildDir.empty() || sourcefile.empty())
-        return;
-
-    const std::string analyzerInfoFile = AnalyzerInformation::getAnalyzerInfoFile(buildDir,sourcefile,cfg,fsFileId);
-    std::ifstream ifs(analyzerInfoFile);
-    if (!ifs.is_open())
-        return;
-
-    std::ostringstream iss;
-    iss << ifs.rdbuf();
-    ifs.close();
-
-    std::string content = iss.str();
-    content.resize(content.find("</analyzerinfo>"));
-
-    mOutputStream.open(analyzerInfoFile, std::ios::trunc);
-    mOutputStream << content;
-}

lib/analyzerinfo.h

@@ -69,8 +69,6 @@ class CPPCHECKLIB AnalyzerInformation {
     void setFileInfo(const std::string &check, const std::string &fileInfo);
     static std::string getAnalyzerInfoFile(const std::string &buildDir, const std::string &sourcefile, const std::string &cfg, std::size_t fsFileId);
 
-    void reopen(const std::string &buildDir, const std::string &sourcefile, const std::string &cfg, std::size_t fsFileId);
-
     static const char sep = ':';
 
     class CPPCHECKLIB Info {