Global var

Author: olabetskyi

cli/cppcheckexecutor.cpp

@@ -271,7 +271,7 @@ int CppCheckExecutor::check(int argc, const char* const argv[])
         return EXIT_SUCCESS;
     }
 
-    Timer realTimeClock("Summary", settings.showtime);
+    Timer realTimeClock(OVERALL_TIMER, settings.showtime);
 
     settings.loadSummaries();
 

lib/timer.cpp

@@ -99,14 +99,14 @@ void Timer::stop()
     if ((mShowTimeMode != SHOWTIME_MODES::SHOWTIME_NONE) && mStartTimePoint != TimePoint{}) {
         Duration diff = std::chrono::duration_cast<Duration>(Clock::now() - mStartTimePoint);
         if (!mTimerResults) {
-            if (mStr == "Summary"
+            if (mStr == OVERALL_TIMER
                 && (mShowTimeMode != SHOWTIME_MODES::SHOWTIME_TOP5_SUMMARY && mShowTimeMode != SHOWTIME_MODES::SHOWTIME_TOP5_FILE && mShowTimeMode != SHOWTIME_MODES::SHOWTIME_SUMMARY))
                 return;
-            if (mStr != "Summary"
+            if (mStr != OVERALL_TIMER
                 && (mShowTimeMode != SHOWTIME_MODES::SHOWTIME_FILE && mShowTimeMode != SHOWTIME_MODES::SHOWTIME_FILE_TOTAL))
                 return;
             std::lock_guard<std::mutex> l(stdCoutLock);
-            std::cout << (mStr == "Summary" ? "Overall time: " : "Check time: " + mStr + ": ")<< durationToString(diff) << std::endl;
+            std::cout << (mStr == OVERALL_TIMER ? "Overall time: " : "Check time: " + mStr + ": ")<< durationToString(diff) << std::endl;
         } else {
             mTimerResults->addResults(mStr, diff);
         }

lib/timer.h

@@ -35,6 +35,8 @@ using Clock = std::chrono::high_resolution_clock;
 using TimePoint = std::chrono::time_point<Clock>;
 using Duration = std::chrono::milliseconds;
 
+constexpr char* OVERALL_TIMER = "Summary";
+
 enum class SHOWTIME_MODES : std::uint8_t {
     SHOWTIME_NONE,
     SHOWTIME_FILE,