fixed #14547 - store absolute path in FileWithDetails (fixes slow start-up with a lot of input files)

Author: firewave

cli/cmdlineparser.cpp

@@ -269,10 +269,10 @@ bool CmdLineParser::fillSettingsFromArgs(int argc, const char* const argv[])
         {
             auto it = filesResolved.begin();
             while (it != filesResolved.end()) {
-                const std::string& absname = Path::getAbsoluteFilePath(it->spath());
+                const std::string& absname = it->abspath();
                 // TODO: log if duplicated files were dropped
                 filesResolved.erase(std::remove_if(std::next(it), filesResolved.end(), [&](const FileWithDetails& entry) {
-                    return Path::getAbsoluteFilePath(entry.spath()) == absname;
+                    return entry.abspath() == absname;
                 }), filesResolved.end());
                 ++it;
             }

lib/filesettings.h

@@ -50,6 +50,7 @@ class FileWithDetails
     {
         mPath = std::move(path);
         mPathSimplified = Path::simplifyPath(mPath);
+        mPathAbsolute = Path::getAbsoluteFilePath(mPath);
     }
 
     const std::string& path() const
@@ -62,6 +63,11 @@ class FileWithDetails
         return mPathSimplified;
     }
 
+    const std::string& abspath() const
+    {
+        return mPathAbsolute;
+    }
+
     std::size_t size() const
     {
         return mSize;
@@ -89,6 +95,7 @@ class FileWithDetails
 private:
     std::string mPath;
     std::string mPathSimplified;
+    std::string mPathAbsolute;
     Standards::Language mLang = Standards::Language::None;
     std::size_t mSize;
     std::size_t mFsFileId{0};