refactor Settings::premium

danmar · danmar · commit e94598eab8b2 · 2025-10-29T21:06:01.000+01:00
diff --git a/cli/cmdlineparser.cpp b/cli/cmdlineparser.cpp
@@ -2196,7 +2196,6 @@ bool CmdLineParser::loadCppcheckCfg()
         mLogger.printError("could not load cppcheck.cfg - " + cfgErr);
         return false;
     }
-    mSettings.premium = startsWith(mSettings.cppcheckCfgProductName, "Cppcheck Premium");
     return true;
 }
 
diff --git a/gui/mainwindow.cpp b/gui/mainwindow.cpp
@@ -1091,8 +1091,6 @@ bool MainWindow::getCppcheckSettings(Settings& settings, Suppressions& supprs)
             return false;
         }
 
-        settings.premium = startsWith(settings.cppcheckCfgProductName, "Cppcheck Premium");
-
         const auto cfgAddons = settings.addons;
         settings.addons.clear();
         for (const std::string& addon : cfgAddons) {
diff --git a/lib/settings.cpp b/lib/settings.cpp
@@ -166,6 +166,7 @@ std::string Settings::loadCppcheckCfg(Settings& settings, Suppressions& suppress
         }
     }
 
+    settings.premium = startsWith(settings.cppcheckCfgProductName, "Cppcheck Premium");
     settings.settingsFiles.emplace_back(std::move(fileName));
 
     return "";

Original file line number	Diff line number	Diff line change
`@@ -2196,7 +2196,6 @@ bool CmdLineParser::loadCppcheckCfg()`
`2196`	`2196`	`mLogger.printError("could not load cppcheck.cfg - " + cfgErr);`
`2197`	`2197`	`return false;`
`2198`	`2198`	`}`
`2199`		`- mSettings.premium = startsWith(mSettings.cppcheckCfgProductName, "Cppcheck Premium");`
`2200`	`2199`	`return true;`
`2201`	`2200`	`}`
`2202`	`2201`
Original file line number	Diff line number	Diff line change
`@@ -1091,8 +1091,6 @@ bool MainWindow::getCppcheckSettings(Settings& settings, Suppressions& supprs)`
`1091`	`1091`	`return false;`
`1092`	`1092`	`}`
`1093`	`1093`
`1094`		`- settings.premium = startsWith(settings.cppcheckCfgProductName, "Cppcheck Premium");`
`1095`		`-`
`1096`	`1094`	`const auto cfgAddons = settings.addons;`
`1097`	`1095`	`settings.addons.clear();`
`1098`	`1096`	`for (const std::string& addon : cfgAddons) {`
Original file line number	Diff line number	Diff line change
`@@ -166,6 +166,7 @@ std::string Settings::loadCppcheckCfg(Settings& settings, Suppressions& suppress`
`166`	`166`	`}`
`167`	`167`	`}`
`168`	`168`
	`169`	`+ settings.premium = startsWith(settings.cppcheckCfgProductName, "Cppcheck Premium");`
`169`	`170`	`settings.settingsFiles.emplace_back(std::move(fileName));`
`170`	`171`
`171`	`172`	`return "";`