Revert "mitigated bugprone-exception-escape clang-tidy warnings"

This reverts commit bfa65c2.

Author: firewave

gui/main.cpp

@@ -45,7 +45,6 @@ static void ShowUsage();
 static void ShowVersion();
 static bool CheckArgs(const QStringList &args);
 
-// NOLINTNEXTLINE(bugprone-exception-escape)
 int main(int argc, char *argv[])
 {
     QApplication app(argc, argv);

lib/ctu.h

@@ -109,7 +109,6 @@ namespace CTU {
             bool loadBaseFromXml(const tinyxml2::XMLElement *xmlElement);
         };
 
-        // NOLINTNEXTLINE(bugprone-exception-escape)
         class FunctionCall : public CallBase {
         public:
             std::string callArgumentExpression;
@@ -122,7 +121,6 @@ namespace CTU {
             bool loadFromXml(const tinyxml2::XMLElement *xmlElement);
         };
 
-        // NOLINTNEXTLINE(bugprone-exception-escape)
         class NestedCall : public CallBase {
         public:
             NestedCall() = default;

lib/importproject.cpp

@@ -909,7 +909,6 @@ bool ImportProject::importVcxproj(const std::string &filename, const tinyxml2::X
 
 ImportProject::SharedItemsProject ImportProject::importVcxitems(const std::string& filename, const std::vector<std::string>& fileFilters, std::vector<SharedItemsProject> &cache)
 {
-    // NOLINTNEXTLINE(bugprone-exception-escape)
     auto isInCacheCheck = [filename](const ImportProject::SharedItemsProject& e) -> bool {
         return filename == e.pathToProjectFile;
     };

lib/templatesimplifier.cpp

@@ -74,7 +74,6 @@ namespace {
         const Token * const mToken;
     };
 
-    // NOLINTNEXTLINE(bugprone-exception-escape)
     class FindName {
     public:
         explicit FindName(std::string name) : mName(std::move(name)) {}
@@ -85,7 +84,6 @@ namespace {
         const std::string mName;
     };
 
-    // NOLINTNEXTLINE(bugprone-exception-escape)
     class FindFullName {
     public:
         explicit FindFullName(std::string fullName) : mFullName(std::move(fullName)) {}

lib/tokenlist.cpp

@@ -1841,7 +1841,6 @@ namespace {
     struct OnException {
         std::function<void()> f;
 
-        // NOLINTNEXTLINE(bugprone-exception-escape)
         ~OnException() {
 #ifndef _MSC_VER
             if (std::uncaught_exception())

lib/utils.h

@@ -54,7 +54,6 @@ struct SelectMapValues {
 struct OnExit {
     std::function<void()> f;
 
-    // NOLINTNEXTLINE(bugprone-exception-escape) - reported with libc++ for any files which includes this (even if not used)
     ~OnExit() {
         f();
     }

tools/dmake/dmake.cpp

@@ -414,7 +414,6 @@ static void write_ossfuzz_makefile(std::vector<std::string> libfiles_prio, std::
     fout << "\t$(CXX) ${LIB_FUZZING_ENGINE} $(CPPFLAGS) $(CXXFLAGS) -DNO_FUZZ -c -o $@ main.cpp\n";
 }
 
-// NOLINTNEXTLINE(bugprone-exception-escape)
 int main(int argc, char **argv)
 {
     const bool release(argc >= 2 && std::string(argv[1]) == "--release");