SymbolDatabase: do not pass in references to Settings and ErrorLogger / some related parameter passing cleanups#7050
Merged
Conversation
Collaborator
Author
|
I have some changes which might need to access something which seems not available in the context. So I am looking in consolidating these references which refer to objects which exist only once into a context so we do not need to keep passing/storing them separately at any layer. It should also make things clearer as we will no longer access these via various routes. |
Collaborator
Author
|
Leads to a minor performance regression so might need some caching. |
firewave
force-pushed
the
scope-symdb
branch
2 times, most recently
from
3f78862 to
4be9c3c
Compare
firewave
force-pushed
the
scope-symdb
branch
2 times, most recently
from
697aa41 to
23af22d
Compare
firewave
changed the title
Settings and ErrorLogger / some related parameter passing cleanupsSettings and ErrorLogger / some related parameter passing cleanups
firewave
changed the title
Settings and ErrorLogger / some related parameter passing cleanupsSettings and ErrorLogger / some related parameter passing cleanups
Collaborator
Author
I restored the storing of the references in |
firewave
changed the title
Settings and ErrorLogger / some related parameter passing cleanupsSettings and ErrorLogger / some related parameter passing cleanups
danmar
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.